Fix ethernet commissioning for esp32 #25876

PSONALl · 2023-03-29T07:14:10Z

Added missing implementations of ethernet driver instance for esp32
Tested ethernet commissioning and control

github-actions · 2023-03-29T07:31:45Z

PR #25876: Size comparison from a193746 to 915edd7

Full report (1 build for cc32xx)

platform	target	config	section	`a193746`	`915edd7`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	645745	645745
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933102	933102
			.debug_aranges	87704	87704
			.debug_frame	301604	301604
			.debug_info	20309905	20309905
			.debug_line	2680953	2680953
			.debug_loc	2827596	2827596
			.debug_ranges	286376	286376
			.debug_str	3041114	3041114
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105953	105953
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	380555	380555
			.symtab	257456	257456
			.text	537672	537672

github-actions · 2023-03-29T09:09:09Z

PR #25876: Size comparison from a193746 to 7183647

Increases (1 build for cc32xx)

platform	target	config	section	`a193746`	`7183647`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20309905	20309906	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`a193746`	`7183647`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645745	645745	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933102	933102	0
			.debug_aranges	87704	87704	0
			.debug_frame	301604	301604	0
			.debug_info	20309905	20309906	1
			.debug_line	2680953	2680953	0
			.debug_loc	2827596	2827596	0
			.debug_ranges	286376	286376	0
			.debug_str	3041114	3041114	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105953	105953	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380555	380555	0
			.symtab	257456	257456	0
			.text	537672	537672	0

examples/platform/esp32/common/Esp32AppServer.cpp

src/platform/ESP32/NetworkCommissioningDriver.h

github-actions · 2023-03-30T09:52:35Z

PR #25876: Size comparison from a27bc8c to 3ca49ff

Increases (1 build for cc32xx)

platform	target	config	section	`a27bc8c`	`3ca49ff`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20310043	20310044	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`a27bc8c`	`3ca49ff`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645769	645769	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933102	933102	0
			.debug_aranges	87704	87704	0
			.debug_frame	301596	301596	0
			.debug_info	20310043	20310044	1
			.debug_line	2681003	2681003	0
			.debug_loc	2827360	2827360	0
			.debug_ranges	286352	286352	0
			.debug_str	3041144	3041144	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105953	105953	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380543	380543	0
			.symtab	257472	257472	0
			.text	537696	537696	0

github-actions · 2023-03-31T13:33:30Z

PR #25876: Size comparison from 62f2bb4 to 7283dec

Increases (1 build for cc32xx)

platform	target	config	section	`62f2bb4`	`7283dec`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20310330	20310331	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`62f2bb4`	`7283dec`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645825	645825	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933102	933102	0
			.debug_aranges	87704	87704	0
			.debug_frame	301596	301596	0
			.debug_info	20310330	20310331	1
			.debug_line	`2681125`	`2681125`	0
			.debug_loc	`2827568`	`2827568`	0
			.debug_ranges	286448	286448	0
			.debug_str	3041144	3041144	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105953	105953	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380543	380543	0
			.symtab	257472	257472	0
			.text	537752	537752	0

src/platform/ESP32/NetworkCommissioningDriver.h

github-actions · 2023-04-10T05:13:42Z

PR #25876: Size comparison from 03cb5e3 to d598ec3

Decreases (1 build for cc32xx)

platform	target	config	section	`03cb5e3`	`d598ec3`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20303341	20303340	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`03cb5e3`	`d598ec3`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	642945	642945	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933129	933129	0	0.0
			.debug_aranges	87616	87616	0	0.0
			.debug_frame	301352	301352	0	0.0
			.debug_info	20303341	20303340	-1	-0.0
			.debug_line	2679963	2679963	0	0.0
			.debug_loc	2824782	2824782	0	0.0
			.debug_ranges	286208	286208	0	0.0
			.debug_str	`3039557`	`3039557`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104353	104353	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377533	377533	0	0.0
			.symtab	256800	256800	0	0.0
			.text	536472	536472	0	0.0

src/platform/ESP32/ConnectivityManagerImpl_Ethernet.cpp

github-actions · 2023-04-12T09:34:35Z

PR #25876: Size comparison from d85124e to dbdb758

Full report (1 build for cc32xx)

platform	target	config	section	`d85124e`	`dbdb758`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642953	642953
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933129	933129
			.debug_aranges	87616	87616
			.debug_frame	301352	301352
			.debug_info	20303347	20303347
			.debug_line	2679969	2679969
			.debug_loc	2824782	2824782
			.debug_ranges	286208	286208
			.debug_str	3039567	3039567
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104353	104353
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377533	377533
			.symtab	256800	256800
			.text	536480	536480

github-actions · 2023-04-12T11:15:48Z

PR #25876: Size comparison from d85124e to 7207b31

Full report (1 build for cc32xx)

platform	target	config	section	`d85124e`	`7207b31`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642953	642953
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933129	933129
			.debug_aranges	87616	87616
			.debug_frame	301352	301352
			.debug_info	20303347	20303347
			.debug_line	2679969	2679969
			.debug_loc	2824782	2824782
			.debug_ranges	286208	286208
			.debug_str	3039567	3039567
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104353	104353
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377533	377533
			.symtab	256800	256800
			.text	536480	536480

github-actions · 2023-04-14T05:39:17Z

PR #25876: Size comparison from 62974a0 to 91ecf4c

Increases (1 build for cc32xx)

platform	target	config	section	`62974a0`	`91ecf4c`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20326060	20326062	2	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`62974a0`	`91ecf4c`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643081	643081	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933224	933224	0
			.debug_aranges	87760	87760	0
			.debug_frame	302028	302028	0
			.debug_info	20326060	20326062	2
			.debug_line	`2687403`	`2687403`	0
			.debug_loc	2838361	2838361	0
			.debug_ranges	288040	288040	0
			.debug_str	3042379	3042379	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104393	104393	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377626	377626	0
			.symtab	256832	256832	0
			.text	536568	536568	0

github-actions bot added esp32 examples platform labels Mar 29, 2023

PSONALl force-pushed the ethernet-fix branch from 915edd7 to 7183647 Compare March 29, 2023 08:57

pullapprove bot added the review - pending label Mar 29, 2023

bzbarsky-apple requested changes Mar 29, 2023

View reviewed changes

examples/platform/esp32/common/Esp32AppServer.cpp Outdated Show resolved Hide resolved

src/platform/ESP32/NetworkCommissioningDriver.h Outdated Show resolved Hide resolved

src/platform/ESP32/NetworkCommissioningDriver.h Outdated Show resolved Hide resolved

PSONALl force-pushed the ethernet-fix branch 3 times, most recently from a45faf5 to 3ca49ff Compare March 30, 2023 09:34

PSONALl force-pushed the ethernet-fix branch from 3ca49ff to 7283dec Compare March 31, 2023 13:21

bzbarsky-apple approved these changes Mar 31, 2023

View reviewed changes

src/platform/ESP32/NetworkCommissioningDriver.h Show resolved Hide resolved

PSONALl force-pushed the ethernet-fix branch from 7283dec to 46adb63 Compare April 3, 2023 04:46

PSONALl force-pushed the ethernet-fix branch from 46adb63 to d598ec3 Compare April 10, 2023 04:58

dhrishi reviewed Apr 10, 2023

View reviewed changes

src/platform/ESP32/ConnectivityManagerImpl_Ethernet.cpp Show resolved Hide resolved

PSONALl mentioned this pull request Apr 12, 2023

Ethernet and Wi-Fi support? (CON-353) espressif/esp-matter#271

Closed

PSONALl force-pushed the ethernet-fix branch from d598ec3 to dbdb758 Compare April 12, 2023 09:22

PSONALl force-pushed the ethernet-fix branch from dbdb758 to af21f21 Compare April 12, 2023 10:58

github-actions bot added the documentation Improvements or additions to documentation label Apr 12, 2023

PSONALl force-pushed the ethernet-fix branch from af21f21 to 7207b31 Compare April 12, 2023 11:02

andy31415 approved these changes Apr 12, 2023

View reviewed changes

andy31415 enabled auto-merge (squash) April 12, 2023 15:12

Fix ethernet commissioning for esp32

91ecf4c

auto-merge was automatically disabled April 14, 2023 05:28
Head branch was pushed to by a user without write access

PSONALl force-pushed the ethernet-fix branch from 7207b31 to 91ecf4c Compare April 14, 2023 05:28

pullapprove bot added review - approved and removed review - pending labels Apr 14, 2023

yufengwangca merged commit b5db11f into project-chip:master Apr 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ethernet commissioning for esp32 #25876

Fix ethernet commissioning for esp32 #25876

PSONALl commented Mar 29, 2023

github-actions bot commented Mar 29, 2023

github-actions bot commented Mar 29, 2023

github-actions bot commented Mar 30, 2023

github-actions bot commented Mar 31, 2023

github-actions bot commented Apr 10, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 14, 2023

Fix ethernet commissioning for esp32 #25876

Fix ethernet commissioning for esp32 #25876

Conversation

PSONALl commented Mar 29, 2023

github-actions bot commented Mar 29, 2023

github-actions bot commented Mar 29, 2023

github-actions bot commented Mar 30, 2023

github-actions bot commented Mar 31, 2023

github-actions bot commented Apr 10, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 14, 2023