Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify global git safe.directory config outside of CI #25857

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Don't modify global git safe.directory config outside of CI #25857

merged 1 commit into from
Apr 5, 2023

Conversation

ksperling-apple
Copy link
Contributor

@ksperling-apple ksperling-apple commented Mar 27, 2023 •
edited
Loading

Adding CHIP_ROOT as a safe directory is now gated by a --allow-changing-global-git-config flag which is added to all the calls from CI scripts (but not e.g. the Darwin chip_xcode_build_connector). Also avoid adding the directory again if it's already in the list.

@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from 22a9731 to 41d30a3 Compare March 27, 2023 23:45
@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from 41d30a3 to 0a3a008 Compare March 28, 2023 01:48
@github-actions
Copy link

PR #25857: Size comparison from def9802 to 0a3a008

Full report (1 build for cc32xx)
platform target config section def9802 0a3a008 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309907 20309907 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from 0a3a008 to e6d67d0 Compare March 28, 2023 02:33
@github-actions
Copy link

PR #25857: Size comparison from def9802 to e6d67d0

Full report (1 build for cc32xx)
platform target config section def9802 e6d67d0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309907 20309907 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from e6d67d0 to b109ba9 Compare March 28, 2023 03:32
@ksperling-apple ksperling-apple changed the title See what fails when we don't mess with safe.directory Don't modify global git safe.directory config outside of CI Mar 28, 2023
@github-actions
Copy link

PR #25857: Size comparison from def9802 to b109ba9

Decreases (1 build for cc32xx)
platform target config section def9802 b109ba9d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20309907 20309906 -1 -0.0
Full report (1 build for cc32xx)
platform target config section def9802 b109ba9d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309907 20309906 -1 -0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0

@ksperling-apple ksperling-apple marked this pull request as ready for review March 28, 2023 20:44
@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from b109ba9 to 6f94299 Compare March 29, 2023 21:05
@github-actions
Copy link

PR #25857: Size comparison from 2aefaa6 to 6f94299

Decreases (1 build for cc32xx)
platform target config section 2aefaa6 6f94299 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310044 20310043 -1 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 2aefaa6 6f94299 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645769 645769 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310044 20310043 -1 -0.0
.debug_line 2681024 2681024 0 0.0
.debug_loc 2827360 2827360 0 0.0
.debug_ranges 286352 286352 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537696 537696 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152952 1152952 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 600048 600048 0 0.0
lock-app qpg6105+debug (read/write) 1121528 1121528 0 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568628 568628 0 0.0

@ksperling-apple
Don't modify global git safe.directory config outside of CI
e313a84 
Adding CHIP_ROOT as a safe directory is now gated by a --configure flag which is added to all the calls from CI scripts (but not e.g. the Darwin chip_xcode_build_connector). Also avoid adding the directory again if it's already in the list.
@ksperling-apple ksperling-apple force-pushed the dont-modify-git-config branch from 6f94299 to e313a84 Compare March 31, 2023 03:57
@github-actions
Copy link

PR #25857: Size comparison from ce0ddc0 to e313a84

Full report (1 build for cc32xx)
platform target config section ce0ddc0 e313a84 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310331 20310331 0 0.0
.debug_line 2681125 2681125 0 0.0
.debug_loc 2827568 2827568 0 0.0
.debug_ranges 286448 286448 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537752 537752 0 0.0

@andy31415 andy31415 merged commit 3cddcc6 into project-chip:master Apr 5, 2023
@ksperling-apple ksperling-apple deleted the dont-modify-git-config branch April 23, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples github integrations review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksperling-apple @andy31415 @bzbarsky-apple