-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs]Rework EFR32 spi com to rs9116/siwx917 wifi ncp #25834
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:rework_spi_sem
Mar 28, 2023
Merged
[Silabs]Rework EFR32 spi com to rs9116/siwx917 wifi ncp #25834
jmartinez-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:rework_spi_sem
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmeg-sfy
March 25, 2023 20:19
pullapprove
bot
requested review from
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
March 25, 2023 20:19
pullapprove
bot
requested review from
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
March 25, 2023 20:19
PR #25834: Size comparison from ec2ad41 to 6ecc568 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 27, 2023
To be clear: my approval is mostly a rubber-stamp. @jmartinez-silabs please let me know if you want me to read through things here carefully. |
Thanks @bzbarsky-apple , I believe it is a pretty straightforward cleanup and I'll ask for a thorough review from Silabs folks. It has also been tested in our internal wifi testbench Thanks! |
jmeg-sfy
reviewed
Mar 27, 2023
jmeg-sfy
reviewed
Mar 27, 2023
jmeg-sfy
reviewed
Mar 27, 2023
jmeg-sfy
approved these changes
Mar 27, 2023
mkardous-silabs
approved these changes
Mar 28, 2023
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework EFR32 platforms + wifi ncp radio rs9116 or siwx917 spi communication to use our
spidrv
and improve the synchronization mechanism for the dma transfer