Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order logic in no-codegen-expected check #25828

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Fix order logic in no-codegen-expected check #25828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9d1c81
Fix order logic in codegen check
andreilitvin Mar 24, 2023
78d582c
Fix the reporting order too
andreilitvin Mar 24, 2023
afbf727
Merge branch 'master' into fix_codegen_check
andy31415 Apr 5, 2023
facd260
Ensure "no codegen" check is done against a clean output.
andy31415 Apr 5, 2023
cc87a0c
Fix bloat check location
andy31415 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ jobs:
run: |
./scripts/run_in_build_env.sh "./scripts/codepregen.py ./zzz_pregenerated"
mv scripts/codegen.py scripts/codegen.py.renamed
- name: Clean output
run: rm -rf ./out
- name: Build using build_examples.py (pregen)
timeout-minutes: 60
run: |
Expand All @@ -273,10 +275,10 @@ jobs:
"
- name: Check no code generation in output
run: |
CNT=$(find -name "CHIPClusters.h" out | wc -l)
CNT=$(find out -name "CHIPClusters.h" | wc -l)
if [ "${CNT}" != "0" ]; then
echo "ERROR: found unexpected generated files:"
find -name "CHIPClusters.h" out
find out -name "CHIPClusters.h"
exit 1
fi
- name: Undo code pre-generation changes (make compile time codegen work again)
Expand Down
18 changes: 10 additions & 8 deletions .github/workflows/examples-esp32.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,18 @@ jobs:
build \
--copy-artifacts-to out/artifacts \
"
- name: Prepare bloat report
run: |
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
esp32 m5stack all-clusters-app \
out/esp32-m5stack-all-clusters/chip-all-clusters-app.elf \
/tmp/bloat_reports/
- name: Prepare code pregen and ensure compile time pregen not possible
run: |
./scripts/run_in_build_env.sh "./scripts/codepregen.py ./zzz_pregenerated"
mv scripts/codegen.py scripts/codegen.py.renamed
- name: Clean output
run: rm -rf ./out
- name: Build some M5Stack variations with pregen
timeout-minutes: 60
run: |
Expand All @@ -105,22 +113,16 @@ jobs:
"
- name: Check no code generation in output
run: |
CNT=$(find -name "CHIPClusters.h" out | wc -l)
CNT=$(find out -name "CHIPClusters.h" | wc -l)
if [ "${CNT}" != "0" ]; then
echo "ERROR: found unexpected generated files:"
find -name "CHIPClusters.h" out
find out -name "CHIPClusters.h"
exit 1
fi
- name: Undo code pregeneration changes
run: |
rm -rf ./zzz_pregenerated
mv scripts/codegen.py.renamed scripts/codegen.py
- name: Prepare bloat report
run: |
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
esp32 m5stack all-clusters-app \
out/esp32-m5stack-all-clusters/chip-all-clusters-app.elf \
/tmp/bloat_reports/
- name: Build example All Clusters App C3
timeout-minutes: 15
run: scripts/examples/esp_example.sh all-clusters-app sdkconfig_c3devkit.defaults
Expand Down
2 changes: 0 additions & 2 deletions scripts/setup/requirements.esp32.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ kconfiglib==13.7.1
construct==2.10.54
python-socketio<5
gdbgui==0.13.2.0 ; platform_machine != 'aarch64' and sys_platform == 'linux'
jinja2<3.1
itsdangerous<2.1