Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to ask a ReadClient what its liveness check timeout is. #25804

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add a way to ask a ReadClient what its liveness check timeout is. #25804

merged 1 commit into from
Mar 24, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the app label Mar 23, 2023
@github-actions
Copy link

PR #25804: Size comparison from 7f356db to 56d42d2

Increases (1 build for cc32xx)
platform target config section 7f356db 56d42d2 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 645825 645865 40 0.0
.debug_aranges 87400 87416 16 0.0
.debug_frame 300336 300404 68 0.0
.debug_info 20239635 20241913 2278 0.0
.debug_line 2661958 2662366 408 0.0
.debug_loc 2806731 2807305 574 0.0
.debug_ranges 283424 283464 40 0.0
.debug_str 3027815 3028586 771 0.0
.strtab 380469 380574 105 0.0
.symtab 257408 257456 48 0.0
.text 537712 537752 40 0.0
Full report (1 build for cc32xx)
platform target config section 7f356db 56d42d2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645865 40 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87416 16 0.0
.debug_frame 300336 300404 68 0.0
.debug_info 20239635 20241913 2278 0.0
.debug_line 2661958 2662366 408 0.0
.debug_loc 2806731 2807305 574 0.0
.debug_ranges 283424 283464 40 0.0
.debug_str 3027815 3028586 771 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380574 105 0.0
.symtab 257408 257456 48 0.0
.text 537712 537752 40 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the expose-negotiated-maxinterval branch from 56d42d2 to 644e524 Compare March 23, 2023 15:35
@github-actions
Copy link

PR #25804: Size comparison from ed32443 to 644e524

Increases (1 build for cc32xx)
platform target config section ed32443 644e524 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 645825 645865 40 0.0
.debug_aranges 87400 87416 16 0.0
.debug_frame 300336 300404 68 0.0
.debug_info 20239633 20241914 2281 0.0
.debug_line 2661958 2662366 408 0.0
.debug_loc 2806731 2807305 574 0.0
.debug_ranges 283424 283464 40 0.0
.debug_str 3027815 3028586 771 0.0
.strtab 380469 380574 105 0.0
.symtab 257408 257456 48 0.0
.text 537712 537752 40 0.0
Full report (1 build for cc32xx)
platform target config section ed32443 644e524 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645865 40 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87416 16 0.0
.debug_frame 300336 300404 68 0.0
.debug_info 20239633 20241914 2281 0.0
.debug_line 2661958 2662366 408 0.0
.debug_loc 2806731 2807305 574 0.0
.debug_ranges 283424 283464 40 0.0
.debug_str 3027815 3028586 771 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380574 105 0.0
.symtab 257408 257456 48 0.0
.text 537712 537752 40 0.0

@andy31415 andy31415 merged commit 97f1685 into project-chip:master Mar 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the expose-negotiated-maxinterval branch March 24, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @woody-apple