Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simulated app to python builder and update cert docker image #25754

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Add simulated app to python builder and update cert docker image #25754

merged 1 commit into from
Mar 21, 2023
+23 −3

Conversation

krypton36
Copy link
Contributor

Summary:

Testing:

  • Validated that python builder builds the simulated app with the docker command.

@github-actions
Copy link

PR #25754: Size comparison from 974f620 to d6e68a4

Increases (1 build for cc32xx)
platform target config section 974f620 d6e68a4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248009 20248011 2 0.0
Full report (1 build for cc32xx)
platform target config section 974f620 d6e68a4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300316 300316 0 0.0
.debug_info 20248009 20248011 2 0.0
.debug_line 2661469 2661469 0 0.0
.debug_loc 2805592 2805592 0 0.0
.debug_ranges 283208 283208 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@krypton36 krypton36 mentioned this pull request Mar 20, 2023
Closed
@krypton36 krypton36 force-pushed the AddSimulatedToPythonBuilderAndCertDocker branch from d6e68a4 to 8e23ac9 Compare March 20, 2023 20:35
@raju-apple
Copy link
Contributor

@andy31415 Can you review this as well please ? Fix for #25734

@github-actions
Copy link

PR #25754: Size comparison from 784aad3 to 2ea9102

Increases (1 build for cc32xx)
platform target config section 784aad3 2ea9102 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248022 20248023 1 0.0
Full report (1 build for cc32xx)
platform target config section 784aad3 2ea9102 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248022 20248023 1 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@krypton36 krypton36 force-pushed the AddSimulatedToPythonBuilderAndCertDocker branch 2 times, most recently from 4b4e059 to a6646bb Compare March 20, 2023 22:16
@krypton36 krypton36 requested a review from andy31415 March 20, 2023 22:18
@github-actions
Copy link

PR #25754: Size comparison from a8242ff to a6646bb

Increases (1 build for cc32xx)
platform target config section a8242ff a6646bb change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248021 20248022 1 0.0
Full report (1 build for cc32xx)
platform target config section a8242ff a6646bb change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248021 20248022 1 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@raju-apple
Copy link
Contributor

Thanks @krypton36 , can we merge this in @andy31415 ? I can make the TH release for 1.1 and close out the release for Spring :)

@krypton36 krypton36 force-pushed the AddSimulatedToPythonBuilderAndCertDocker branch from a6646bb to e5037f5 Compare March 21, 2023 16:39
@github-actions
Copy link

PR #25754: Size comparison from 934a6b1 to e5037f5

Full report (1 build for cc32xx)
platform target config section 934a6b1 e5037f5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248022 20248022 0 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove scripts/examples/gn_build_test_example.sh, or change it to simply run the python builder, so we have one less thing to maintain? Followup for either one of those options if we want to take them.

@krypton36
Copy link
Contributor Author

Should we just remove scripts/examples/gn_build_test_example.sh, or change it to simply run the python builder, so we have one less thing to maintain? Followup for either one of those options if we want to take them.

I think removing it, would be ideal. Just have to figure out if there is anything depending on it. Created an issue.

@raju-apple
Copy link
Contributor

Should we just remove scripts/examples/gn_build_test_example.sh, or change it to simply run the python builder, so we have one less thing to maintain? Followup for either one of those options if we want to take them.

I think removing it, would be ideal. Just have to figure out if there is anything depending on it. Created an issue.

Can we merge this in now , so that we can get unblocked from creating a docker image for the TH and then remove / update the gn_build_test_example.sh in a separate PR ?

@bzbarsky-apple
Copy link
Contributor

Can we merge this in now

@raju-apple Nothing above blocks this merging. It's just waiting on CI to pass.

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) March 21, 2023 18:27
@bzbarsky-apple bzbarsky-apple merged commit 47bf1fa into project-chip:master Mar 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@krypton36
Add simulated app to python builder and update cert docker image (pro…
ca614a9 
…ject-chip#25754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415

@amitnj amitnj

@anush-apple anush-apple

@arkq arkq

@carol-apple carol-apple

@chrisdecenzo chrisdecenzo

@chshu chshu

@chulspro chulspro

@cliffamzn cliffamzn

@CodeChronos928 CodeChronos928

@Damian-Nordic Damian-Nordic

@dhrishi dhrishi

@electrocucaracha electrocucaracha

@franck-apple franck-apple

@gjc13 gjc13

@harimau-qirex harimau-qirex

@harsha-rajendran harsha-rajendran

@hawk248 hawk248

@jelderton jelderton

@jepenven-silabs jepenven-silabs

@jmartinez-silabs jmartinez-silabs

@jmeg-sfy jmeg-sfy

@joonhaengHeo joonhaengHeo

@jtung-apple jtung-apple

@kcoppock kcoppock

@kkasperczyk-no kkasperczyk-no

@ksperling-apple ksperling-apple

@lazarkov lazarkov

@lpbeliveau-silabs lpbeliveau-silabs

@LuDuda LuDuda

@mrjerryjohns mrjerryjohns

@msandstedt msandstedt

@mspang mspang

@nivi-apple nivi-apple

@saurabhst saurabhst

@selissia selissia

@sharadb-amazon sharadb-amazon

@tcarmelveilleux tcarmelveilleux

@tecimovic tecimovic

@tehampson tehampson

@turon turon

@vijs vijs

@vivien-apple vivien-apple

@woody-apple woody-apple

@xylophone21 xylophone21

@younghak-hwang younghak-hwang

@yunhanw-google yunhanw-google

@bzbarsky-apple bzbarsky-apple

Assignees
No one assigned
Labels
integrations review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Chip-cert-bins docker script failing on TOT
4 participants
@krypton36 @raju-apple @bzbarsky-apple @andy31415