Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configurable build time versioning of efr32 #25732

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Allow configurable build time versioning of efr32 #25732

merged 8 commits into from
Mar 23, 2023

Conversation

mykrupp
Copy link
Contributor

@mykrupp mykrupp commented Mar 17, 2023

This PR allows a user to configure sl_matter_version, sl_matter_version_str at sl_hardware_version by passing them as command line inputs to gn_efr32_example.sh

@mykrupp mykrupp force-pushed the configure_software_version branch 2 times, most recently from 4fc1f6d to 7a6caaf Compare March 17, 2023 16:40
@mykrupp mykrupp marked this pull request as ready for review March 17, 2023 16:41
@github-actions
Copy link

PR #25732: Size comparison from bbb8e93 to 7a6caaf

Increases (1 build for cc32xx)
platform target config section bbb8e93 7a6caaf change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20246022 2024602 2 0.0
Full report (1 build for cc32xx)
platform target config section bbb8e93 7a6caaf change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 20246022 2024602 2 0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

jmartinez-silabs
jmartinez-silabs requested changes Mar 17, 2023
View reviewed changes
src/platform/silabs/CHIPDevicePlatformConfig.h Outdated Show resolved Hide resolved
scripts/examples/gn_efr32_example.sh Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #25732: Size comparison from bbb8e93 to 391be55

Increases (2 builds for cc32xx, mbed)
platform target config section bbb8e93 391be55 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 645489 645609 120 0.0
.debug_aranges 87392 87400 8 0.0
.debug_frame 300284 300316 32 0.0
.debug_info 20246022 20248010 1988 0.0
.debug_line 2661031 2661469 438 0.0
.debug_loc 2804874 2805592 718 0.0
.debug_ranges 283152 283208 56 0.0
.debug_str 3027037 3027174 137 0.0
.strtab 380331 380421 90 0.0
.symtab 257376 257408 32 0.0
.text 537376 537496 120 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2468360 2468424 64 0.0
.text 1431004 1431068 64 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section bbb8e93 391be55 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645609 120 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87400 8 0.0
.debug_frame 300284 300316 32 0.0
.debug_info 20246022 20248010 1988 0.0
.debug_line 2661031 2661469 438 0.0
.debug_loc 2804874 2805592 718 0.0
.debug_ranges 283152 283208 56 0.0
.debug_str 3027037 3027174 137 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380421 90 0.0
.symtab 257376 257408 32 0.0
.text 537376 537496 120 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468360 2468424 64 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431004 1431068 64 0.0

@mykrupp mykrupp force-pushed the configure_software_version branch from d618679 to 00ea2c8 Compare March 22, 2023 15:42
@github-actions
Copy link

PR #25732: Size comparison from 6be032d to 00ea2c8

Increases (1 build for cc32xx)
platform target config section 6be032d 00ea2c8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251230 20251232 2 0.0
Full report (1 build for cc32xx)
platform target config section 6be032d 00ea2c8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251230 20251232 2 0.0
.debug_line 2661959 2661959 0 0.0
.debug_loc 2806733 2806733 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3027534 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@selissia selissia merged commit 7f356db into project-chip:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selissia selissia selissia left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
examples platform review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mykrupp @andy31415 @selissia @jmartinez-silabs @restyled-commits