Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Do not fail if BLE is already connected #25725

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Mar 17, 2023

Problem

If commissionee device is already connected (e.g. previous commissioning has failed after BLE connection, and it was restarted), Tizen will report BLE connection as failed...

Changes

  • handle BT_ERROR_ALREADY_DONE result code as not an error

Testing

Tested manually with chip-tool pairing ble-wifi 1 <SSID> <pass> 20202021 3840 on Tizen:

I/CHIP    (  914): DL: Gatt Connection State Changed [4265607427]: Connected         <--- 4265607427 == BT_ERROR_ALREADY_DONE
I/CHIP    (  914): DL: Device Connected [B8:27:EB:5E:BA:83]
I/CHIP    (  914): DL: AddConnectionData for [B8:27:EB:5E:BA:83]

@github-actions
Copy link

PR #25725: Size comparison from 379cde1 to dc6923d

Decreases (1 build for cc32xx)
platform target config section 379cde1 dc6923d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2024602 20246023 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 379cde1 dc6923d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300284 300284 0 0.0
.debug_info 2024602 20246023 -1 -0.0
.debug_line 2661031 2661031 0 0.0
.debug_loc 2804874 2804874 0 0.0
.debug_ranges 283152 283152 0 0.0
.debug_str 3027037 3027037 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380331 380331 0 0.0
.symtab 257376 257376 0 0.0
.text 537376 537376 0 0.0

@arkq arkq merged commit 8caa797 into project-chip:master Mar 18, 2023
@arkq arkq deleted the tizen-ble-already-connected branch March 18, 2023 07:47
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* [Tizen] Do not fail if BLE is already connected

* Show error message in case of BLE connection failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants