Deprecating chip_server_cluster_attributes and if_basic_global_response #25693

brdandu · 2023-03-15T14:28:39Z

Replacing a state helper such as chip_server_cluster_attributes with a stateless helper zcl_attributes_server such that we can get deprecate the stateful helpers one by one. Also deprecating if_basic_global_response with if_basic_attribute.

The generation diff that is being seen here pertains to generating all server attributes for the corresponding client clusters instead of hacking the server attributes in the zap file. The hack here referes to how server attributes being generated are those attributes which have been enabled without the corresponding server cluster enabled. To avoid this hack, the code now generates all server attributes for the corresponding client cluster. This seems to be in sync with the non java/python templates in terms of generation. Another generation diff seen here is that there is no basic global response for certain attributes which refer to atomic types such as group_id and vendor_id. I am not sure why that is the case. These attributes seem basic enough. Github: ZAP#898

Some more context can be found at https://csamembers.slack.com/archives/C01B01GH64E/p1678122784057439

github-actions · 2023-03-15T14:41:43Z

PR #25693: Size comparison from a9e759b to 8ef2aab

Full report (1 build for cc32xx)

platform	target	config	section	`a9e759b`	`8ef2aab`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	645489	645489
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930293	930293
			.debug_aranges	87384	87384
			.debug_frame	300248	300248
			.debug_info	20245969	20245969
			.debug_line	`2660979`	`2660979`
			.debug_loc	2804911	2804911
			.debug_ranges	283168	283168
			.debug_str	`3026947`	`3026947`
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	106009	106009
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	380271	380271
			.symtab	257312	257312
			.text	537360	537360

github-actions · 2023-03-20T14:00:53Z

PR #25693: Size comparison from 804892e to 2750c97

Increases (1 build for cc32xx)

platform	target	config	section	`804892e`	`2750c97`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20248010	20248011	1	0.0

Full report (2 builds for cc32xx, mbed)

platform	target	config	section	`804892e`	`2750c97`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645601	645601	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930289	930289	0
			.debug_aranges	87400	87400	0
			.debug_frame	300316	300316	0
			.debug_info	20248010	20248011	1
			.debug_line	2661469	2661469	0
			.debug_loc	2805592	2805592	0
			.debug_ranges	283208	283208	0
			.debug_str	3027174	3027174	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105993	105993	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380421	380421	0
			.symtab	257408	257408	0
			.text	537488	537488	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2468424	2468424	0
			.bss	215964	215964	0
			.data	5880	5880	0
			.text	1431068	1431068	0

github-actions · 2023-03-20T15:58:28Z

PR #25693: Size comparison from 974f620 to 98c343b

Increases (1 build for cc32xx)

platform	target	config	section	`974f620`	`98c343b`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20248009	20248010	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`974f620`	`98c343b`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645601	645601	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930289	930289	0
			.debug_aranges	87400	87400	0
			.debug_frame	300316	300316	0
			.debug_info	20248009	20248010	1
			.debug_line	2661469	2661469	0
			.debug_loc	2805592	2805592	0
			.debug_ranges	283208	283208	0
			.debug_str	3027174	3027174	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105993	105993	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380421	380421	0
			.symtab	257408	257408	0
			.text	537488	537488	0

github-actions · 2023-03-20T18:13:03Z

PR #25693: Size comparison from 974f620 to 1a547ed

Increases (1 build for cc32xx)

platform	target	config	section	`974f620`	`1a547ed`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20248009	20248010	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`974f620`	`1a547ed`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645601	645601	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930289	930289	0
			.debug_aranges	87400	87400	0
			.debug_frame	300316	300316	0
			.debug_info	20248009	20248010	1
			.debug_line	2661469	2661469	0
			.debug_loc	2805592	2805592	0
			.debug_ranges	283208	283208	0
			.debug_str	3027174	3027174	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105993	105993	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380421	380421	0
			.symtab	257408	257408	0
			.text	537488	537488	0

github-actions · 2023-03-20T20:11:27Z

PR #25693: Size comparison from 8425d28 to d83ae8a

Decreases (1 build for cc32xx)

platform	target	config	section	`8425d28`	`d83ae8a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20248011	20248010	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`8425d28`	`d83ae8a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645601	645601	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930289	930289	0	0.0
			.debug_aranges	87400	87400	0	0.0
			.debug_frame	300316	300316	0	0.0
			.debug_info	20248011	20248010	-1	-0.0
			.debug_line	2661469	2661469	0	0.0
			.debug_loc	2805592	2805592	0	0.0
			.debug_ranges	283208	283208	0	0.0
			.debug_str	3027174	3027174	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105993	105993	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	380421	380421	0	0.0
			.symtab	257408	257408	0	0.0
			.text	537488	537488	0	0.0

src/controller/java/templates/CHIPReadCallbacks-src.zapt

src/controller/java/templates/CHIPReadCallbacks.zapt

src/controller/java/templates/ChipClusters-java.zapt

src/controller/java/templates/ClusterInfo-java.zapt

…a stateless helper zcl_attributes_server such that we can get deprecate the stateful helpers one by one. Also deprecating if_basic_global_response with if_basic_attribute. The generation diff that is being seen here pertains to generating all server attributes for the corresponding client clusters instead of hacking the server attributes in the zap file. The hack here referes to how server attributes being generated are those attributes which have been enabled without the corresponding server cluster enabled. To avoid this hack, the code now generates all server attributes for the corresponding client cluster. This seems to be in sync with the non java/python templates in terms of generation. Another generation diff seen here is that there is no basic global response for certain attributes which refer to atomic types such as group_id and vendor_id. I am not sure why that is the case. These attributes seem basic enough. Updating the zap being used - Updating min zap version to 3.16 instead of 3.17 - Github: ZAP#898

github-actions · 2023-03-22T17:15:59Z

PR #25693: Size comparison from 6be032d to 8f5ec21

Increases (1 build for cc32xx)

platform	target	config	section	`6be032d`	`8f5ec21`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20251230	20251231	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`6be032d`	`8f5ec21`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	645825	645825	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930286	930286	0
			.debug_aranges	87400	87400	0
			.debug_frame	300336	300336	0
			.debug_info	20251230	20251231	1
			.debug_line	2661959	2661959	0
			.debug_loc	2806733	2806733	0
			.debug_ranges	283424	283424	0
			.debug_str	3027534	3027534	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105993	105993	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	380469	380469	0
			.symtab	257408	257408	0
			.text	537712	537712	0

Github: ZAP#898

…istake during rebase Github: ZAP#898

Github: ZAP#898

src/controller/java/zap-generated/chip/devicecontroller/ClusterInfoMapping.java

src/controller/java/zap-generated/chip/devicecontroller/ClusterReadMapping.java

…ead of an exception like it used to be in the past. Updating the min zap version Github: ZAP#898

…treat things differently anymore

…tesJavaPythonTemplates/ZAP#898

github-actions · 2023-03-23T17:16:20Z

PR #25693: Size comparison from bf14eb2 to cdbb033

Decreases (1 build for cc32xx)

platform	target	config	section	`bf14eb2`	`cdbb033`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20239635	20239634	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`bf14eb2`	`cdbb033`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645825	645825	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930286	930286	0	0.0
			.debug_aranges	87400	87400	0	0.0
			.debug_frame	300336	300336	0	0.0
			.debug_info	20239635	20239634	-1	-0.0
			.debug_line	2661958	2661958	0	0.0
			.debug_loc	`2806731`	`2806731`	0	0.0
			.debug_ranges	283424	283424	0	0.0
			.debug_str	`3027815`	`3027815`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105993	105993	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	380469	380469	0	0.0
			.symtab	257408	257408	0	0.0
			.text	537712	537712	0	0.0

github-actions bot added the controller label Mar 15, 2023

brdandu mentioned this pull request Mar 16, 2023

chip_server_cluster_attributes returning attributes of a clusters which are disabled project-chip/zap#898

Closed

github-actions bot added integrations scripts labels Mar 17, 2023

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch 2 times, most recently from f082aef to 2750c97 Compare March 20, 2023 13:36

andy31415 mentioned this pull request Mar 20, 2023

Enable all thermostat client attributes in controller clusters #25753

Merged

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch from 2750c97 to 98c343b Compare March 20, 2023 15:44

brdandu marked this pull request as ready for review March 20, 2023 18:04

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch from 1a547ed to d83ae8a Compare March 20, 2023 19:55

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch 2 times, most recently from 4551074 to 482683a Compare March 21, 2023 14:48

github-actions bot removed integrations scripts labels Mar 21, 2023

pullapprove bot requested review from amitnj, anush-apple, arkq, bzbarsky-apple, carol-apple, chrisdecenzo, chshu, chulspro, cliffamzn, CodeChronos928 and Damian-Nordic March 21, 2023 14:54

bzbarsky-apple reviewed Mar 21, 2023

View reviewed changes

andy31415 mentioned this pull request Mar 21, 2023

Move ClusterWriteMapping.java to be generated from matter.idl #25773

Merged

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch from d6fbd0a to c720262 Compare March 22, 2023 16:55

brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesJavaPythonTemplates/ZAP#898 branch from c720262 to 8f5ec21 Compare March 22, 2023 17:02

Updating min zap version to 2023-03-22

b7db179

Github: ZAP#898

github-actions bot added integrations scripts labels Mar 22, 2023

brdandu added 2 commits March 22, 2023 13:32

Deleting the file which was deleted in the main chip repo. Added by m…

8e1419b

…istake during rebase Github: ZAP#898

Regen after rebase

4819fda

Github: ZAP#898

andy31415 reviewed Mar 22, 2023

View reviewed changes

src/controller/java/zap-generated/chip/devicecontroller/ClusterInfoMapping.java Show resolved Hide resolved

andy31415 reviewed Mar 22, 2023

View reviewed changes

src/controller/java/zap-generated/chip/devicecontroller/ClusterReadMapping.java Show resolved Hide resolved

brdandu and others added 3 commits March 23, 2023 09:17

Making attributes of type vendor_id to be treated as basic types inst…

b0302fa

…ead of an exception like it used to be in the past. Updating the min zap version Github: ZAP#898

update matter idl template gen logic

22647bc

ZAP regen all

cfd5332

github-actions bot added app examples labels Mar 23, 2023

andy31415 added 4 commits March 23, 2023 10:11

Remove extra newline before commands in server clusters

23d64d0

Adjust whitespace a bit more

5ae19a4

Another whitespace alignment update

06b3ee2

minor whitespace adjustment in zapt comment

652f893

andy31415 approved these changes Mar 23, 2023

View reviewed changes

andy31415 mentioned this pull request Mar 23, 2023

Update MatterIDL codegen to not take into account enabled for client attributes #25737

Closed

andy31415 added 3 commits March 23, 2023 11:46

Remove compatibility workaround for codegen in java - zap should not …

6d8942e

…treat things differently anymore

Make android chip-tool compile

cf699c9

Merge branch 'master' into bug/fixServerSideEnabledClustersAndAttribu…

cdbb033

…tesJavaPythonTemplates/ZAP#898

bzbarsky-apple approved these changes Mar 23, 2023

View reviewed changes

andy31415 merged commit 47c3fe9 into project-chip:master Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecating chip_server_cluster_attributes and if_basic_global_response #25693

Deprecating chip_server_cluster_attributes and if_basic_global_response #25693

brdandu commented Mar 15, 2023 •

edited by andy31415

Loading

github-actions bot commented Mar 15, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 22, 2023

github-actions bot commented Mar 23, 2023

Deprecating chip_server_cluster_attributes and if_basic_global_response #25693

Deprecating chip_server_cluster_attributes and if_basic_global_response #25693

Conversation

brdandu commented Mar 15, 2023 • edited by andy31415 Loading

github-actions bot commented Mar 15, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

github-actions bot commented Mar 22, 2023

github-actions bot commented Mar 23, 2023

brdandu commented Mar 15, 2023 •

edited by andy31415

Loading