-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs]Removed ipv4 flag from example build gn files and added in siw917 sdk #25675
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
Thirsrin:feature/remove_ip4_flag_in_example_build_gn
Mar 15, 2023
Merged
[Silabs]Removed ipv4 flag from example build gn files and added in siw917 sdk #25675
yufengwangca
merged 1 commit into
project-chip:master
from
Thirsrin:feature/remove_ip4_flag_in_example_build_gn
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 14, 2023 05:45
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux and
tecimovic
March 14, 2023 05:45
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
March 14, 2023 05:45
PR #25675: Size comparison from c1810b6 to 615be24 Decreases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
jmartinez-silabs
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the build that was failing yesterday with #25670 but this is of course better. I am just still expecting a siwx917 general build file cleanup which will move a bunch of stuff around also.
bzbarsky-apple
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Removed ipv4 flag from example build gn files and added in siw917 sdk gn file
Tested:
All app builds successfully done for 917 soc