Extend our fail-safe a bit before we try to enable wifi/thread networks. #25667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #25667: Size comparison from d04e396 to e4349e4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Two changes here: 1. Automatic fail-safe extension should not make the fail-safe _shorter_. This should prevent, for example, a short fail-safe on attestation failure overriding a longer initial fail-safe. 2. Before we try to enable network (which is the last time we're guaranteed to be able to talk to a device over PASE, for non-concurrent commissioning flow devices), extend our fail-safe to try to cover the time it will take us to do operational discovery and sending CommissioningComplete.
bzbarsky-apple
force-pushed
the
extend-failsafe-before-enable-network
branch
from
e4349e4 to
1374e49
Compare
|
PR #25667: Size comparison from d04e396 to 1374e49 Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
yunhanw-google
approved these changes
Mar 13, 2023
cliffamzn
approved these changes
Mar 13, 2023
cliffamzn
approved these changes
Mar 13, 2023
|
PR #25667: Size comparison from d04e396 to 57f54ca Increases above 0.2%:
Increases (23 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (13 builds for bl702, cc13x2_26x2, efr32, nrfconnect)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
force-pushed
the
extend-failsafe-before-enable-network
branch
from
07d156c to
75ffaa8
Compare
tcarmelveilleux
approved these changes
Mar 14, 2023
|
PR #25667: Size comparison from 3eac074 to 75ffaa8 Increases (15 builds for cc13x2_26x2, cc32xx, cyw30739, linux, nrfconnect, psoc6)
Decreases (17 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, esp32, k32w, nrfconnect, qpg)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
msandstedt
reviewed
Mar 14, 2023
msandstedt
approved these changes
Mar 14, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ks. (project-chip#25667) * Extend our fail-safe a bit before we try to enable wifi/thread networks. Two changes here: 1. Automatic fail-safe extension should not make the fail-safe _shorter_. This should prevent, for example, a short fail-safe on attestation failure overriding a longer initial fail-safe. 2. Before we try to enable network (which is the last time we're guaranteed to be able to talk to a device over PASE, for non-concurrent commissioning flow devices), extend our fail-safe to try to cover the time it will take us to do operational discovery and sending CommissioningComplete. * Address review comments. * Address review comments.
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
…ks. (project-chip#25667) * Extend our fail-safe a bit before we try to enable wifi/thread networks. Two changes here: 1. Automatic fail-safe extension should not make the fail-safe _shorter_. This should prevent, for example, a short fail-safe on attestation failure overriding a longer initial fail-safe. 2. Before we try to enable network (which is the last time we're guaranteed to be able to talk to a device over PASE, for non-concurrent commissioning flow devices), extend our fail-safe to try to cover the time it will take us to do operational discovery and sending CommissioningComplete. * Address review comments. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
Automatic fail-safe extension should not make the fail-safe shorter. This should prevent, for example, a short fail-safe on attestation failure overriding a longer initial fail-safe.
Before we try to enable network (which is the last time we're guaranteed to be able to talk to a device over PASE, for non-concurrent commissioning flow devices), extend our fail-safe to try to cover the time it will take us to do operational discovery and sending CommissioningComplete.