-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ColorControl]Prevent any chance of division by 0 #25662
Merged
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:check_div0
Mar 13, 2023
Merged
[ColorControl]Prevent any chance of division by 0 #25662
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:check_div0
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 13, 2023 17:25
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 13, 2023 17:25
PR #25662: Size comparison from d1604b3 to 2e54b29 Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Mar 13, 2023
bzbarsky-apple
requested changes
Mar 13, 2023
PR #25662: Size comparison from d1604b3 to ec3f4a2 Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Mar 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Prevent any chance of division by 0 in Colorcontol. Update some C casts to C++ * Address comments
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
* Prevent any chance of division by 0 in Colorcontol. Update some C casts to C++ * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The different color transition values calculations use a division by the Total amount of steps of the transition. From a quick code overview, stepsTotal was always set to a value >= to 1.
Still to be on the kosher side; add checks to prevent any division by 0 and to skip the operation for a division by 1.
this PR also update some C casts to C++