-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Change TLV Parsing variable (Int -> Long, UInt -> ULong) #25646
Merged
andy31415
merged 3 commits into
project-chip:master
from
joonhaengHeo:change_to_long_tlv
Mar 20, 2023
Merged
[Android] Change TLV Parsing variable (Int -> Long, UInt -> ULong) #25646
andy31415
merged 3 commits into
project-chip:master
from
joonhaengHeo:change_to_long_tlv
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25646: Size comparison from bc8c9ec to e2458c0 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
emargolis
approved these changes
Mar 13, 2023
yunhanw-google
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
PR #25646: Size comparison from c7275d6 to 1f0c020 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25646: Size comparison from c1810b6 to 083fefb Full report (4 builds for cc32xx, mbed, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25637
There are two Int variables in the TLV Format.
However, in the case of Kotlin or Java, there are six types: Long, Int, Short, ULong, UInt, and UShort.
To cover all of this, I changed the menu that supports Int and UInt to Long and ULong to support all Int Types.