Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Change TLV Parsing variable (Int -> Long, UInt -> ULong) #25646

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

joonhaengHeo
Copy link
Contributor

Fix #25637
There are two Int variables in the TLV Format.
However, in the case of Kotlin or Java, there are six types: Long, Int, Short, ULong, UInt, and UShort.
To cover all of this, I changed the menu that supports Int and UInt to Long and ULong to support all Int Types.

@github-actions
Copy link

PR #25646: Size comparison from bc8c9ec to e2458c0

Decreases (1 build for cc32xx)
platform target config section bc8c9ec e2458c0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275630 -2 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ec e2458c0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275630 -2 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@github-actions
Copy link

PR #25646: Size comparison from c7275d6 to 1f0c020

Decreases (1 build for cc32xx)
platform target config section c7275d6 1f0c020 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245968 -1 -0.0
Full report (1 build for cc32xx)
platform target config section c7275d6 1f0c020 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245968 -1 -0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804893 2804893 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@github-actions
Copy link

PR #25646: Size comparison from c1810b6 to 083fefb

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section c1810b6 083fefb change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468312 2468312 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430956 1430956 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153444 1153444 0 0.0
.bss 100076 100076 0 0.0
.data 852 852 0 0.0
.text 600540 600540 0 0.0
lock-app qpg6105+debug (read/write) 1120300 1120300 0 0.0
.bss 96468 96468 0 0.0
.data 864 864 0 0.0
.text 567400 567400 0 0.0

@andy31415 andy31415 merged commit d050787 into project-chip:master Mar 20, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need specify more integer type in android chip-tool UI for IM invoke and write
4 participants