Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kotlin test CI and android TV cast example CI #25644

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix kotlin test CI and android TV cast example CI #25644

merged 2 commits into from
Mar 13, 2023

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Mar 12, 2023 •
edited
Loading

-- previous #25636 does not update python wrapper for kotlin im test runtest function, need add missing piece so that CI can pass
-- previous #25505 does not update the subscriptionId in OnEstablishedCallback in example android tv cast side. need update it.

@yunhanw-google yunhanw-google changed the title Fix java test CI Fix kotlin test CI Mar 12, 2023
@github-actions
Copy link

PR #25644: Size comparison from bc8c9ec to d868801

Decreases (1 build for cc32xx)
platform target config section bc8c9ec d868801 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275631 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section bc8c9ec d868801 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275631 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468104 2468104 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430748 1430748 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_kotlin-ci branch from d868801 to ed4754e Compare March 12, 2023 16:43
@github-actions
Copy link

PR #25644: Size comparison from bc8c9ec to ed4754e

Full report (1 build for cc32xx)
platform target config section bc8c9ec ed4754e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275632 0 0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_kotlin-ci branch from ed4754e to 2d2bddc Compare March 12, 2023 17:19
@github-actions
Copy link

PR #25644: Size comparison from bc8c9ec to 2d2bddc

Decreases (1 build for cc32xx)
platform target config section bc8c9ec 2d2bddc change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275631 -1 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ec 2d2bddc change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275631 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@yunhanw-google yunhanw-google enabled auto-merge (squash) March 12, 2023 20:13
@yunhanw-google yunhanw-google changed the title Fix kotlin test CI Fix kotlin test CI and android TV cast example CI Mar 12, 2023
@yunhanw-google yunhanw-google force-pushed the feature/fix_kotlin-ci branch from 0018e08 to 09198ce Compare March 12, 2023 23:19
@github-actions
Copy link

PR #25644: Size comparison from bc8c9ec to 09198ce

Decreases (1 build for cc32xx)
platform target config section bc8c9ec 09198ce change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275631 -1 -0.0
Full report (1 build for cc32xx)
platform target config section bc8c9ec 09198ce change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275631 -1 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

yufengwangca
yufengwangca reviewed Mar 13, 2023
View reviewed changes
scripts/tests/run_java_test.py Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
scripts/tests/java/commissioning_test.py Outdated Show resolved Hide resolved
@yufengwangca
Copy link
Contributor

I saw all of IM commands (read/write/invoke/subscribe) are implemented within pairing cluster, but tested under another cluster 'im', under which clusters those commands are implemented in chip-tool? we need to align with chip--tool. Finally, we should auto-generated the command handlers from its xml cluster definition file

@yunhanw-google yunhanw-google force-pushed the feature/fix_kotlin-ci branch from 09198ce to 045e961 Compare March 13, 2023 05:01
@github-actions
Copy link

PR #25644: Size comparison from bc8c9ec to 045e961

Decreases (1 build for cc32xx)
platform target config section bc8c9ec 045e961 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275632 20275630 -2 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section bc8c9ec 045e961 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275632 20275630 -2 -0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468104 2468104 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430748 1430748 0 0.0

@yunhanw-google
Copy link
Contributor Author

yunhanw-google commented Mar 13, 2023 •
edited
Loading

I saw all of IM commands (read/write/invoke/subscribe) are implemented within pairing cluster, but tested under another cluster 'im', under which clusters those commands are implemented in chip-tool? we need to align with chip--tool. Finally, we should auto-generated the command handlers from its xml cluster definition file

these should be tested in im category, however, we don't have enough bandwidth to figure out how to extract the certs info and setup case connection in these im tests, in addition, standalone case api in jni is not ready. Would file the ticket on it.

#25649

We may use zap to generate a list of test commands later, file the ticket as well.
#25650

thanks

@yufengwangca
Copy link
Contributor

I saw all of IM commands (read/write/invoke/subscribe) are implemented within pairing cluster, but tested under another cluster 'im', under which clusters those commands are implemented in chip-tool? we need to align with chip--tool. Finally, we should auto-generated the command handlers from its xml cluster definition file

these should be tested in im category, however, we don't have enough bandwidth to figure out how to extract the certs info and setup case connection in these im tests, in addition, standalone case api in jni is not ready. Would file the ticket on it.

#25649

We may use zap to generate a list of test commands later, file the ticket as well. #25650

thanks

#25650 is a FR and not imminent, I updated the description of

#25649, this is not about test, the problem is in IM cluster commands implementation, currently, all IM cluster commands are registered under cluster 'im', but implemented as 'pairing' cluster command. The behavior is undefined, if we register a command in one cluster, but implemented it under another cluster. Lets follow-up this after this PR lands

@yunhanw-google yunhanw-google merged commit 0d5837c into project-chip:master Mar 13, 2023
@yunhanw-google yunhanw-google deleted the feature/fix_kotlin-ci branch March 13, 2023 16:21
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@yunhanw-google
Fix Java CI (project-chip#25644)
c812e00
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@yunhanw-google @mwswartwout
Fix Java CI (project-chip#25644)
d5adfc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@joonhaengHeo joonhaengHeo joonhaengHeo approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
examples github review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @joonhaengHeo