Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Adds WiFi flag fix #25631

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[Silabs] Adds WiFi flag fix #25631

merged 3 commits into from
Mar 15, 2023

Conversation

rosahay-silabs
Copy link
Contributor

Adds typo fix for lwip_ipv6 and DHCP flag check for RSI SAPI implementation

@github-actions
Copy link

PR #25631: Size comparison from 3c6bed3 to 545a5c0

Increases (1 build for cc32xx)
platform target config section 3c6bed3 545a5c0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275631 20275632 1 0.0
Full report (1 build for cc32xx)
platform target config section 3c6bed3 545a5c0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275631 20275632 1 0.0
.debug_line 2660982 2660982 0 0.0
.debug_loc 2804957 2804957 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026158 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@rosahay-silabs rosahay-silabs force-pushed the bugfix/wifi-ipv4-lwip-flag-fix branch from 545a5c0 to cd58738 Compare March 15, 2023 13:18
@rosahay-silabs rosahay-silabs changed the title [Silabs] Adds WiFi and LWIP flag fix [Silabs] Adds WiFi flag fix Mar 15, 2023
@github-actions
Copy link

PR #25631: Size comparison from a9e759b to cd58738

Full report (1 build for cc32xx)
platform target config section a9e759b cd58738 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245969 0 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@jepenven-silabs jepenven-silabs merged commit 5648ddd into project-chip:master Mar 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@rosahay-silabs
[Silabs] Adds WiFi flag fix (project-chip#25631)
5ccdb52 
* Adds typo fix lwip_ipv6 flag

* Adds fix for DHCP flag check on SAPI

* Revert "Adds typo fix lwip_ipv6 flag"

This reverts commit cf9b793.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@selissia selissia selissia approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosahay-silabs @yufengwangca @selissia @bzbarsky-apple @jepenven-silabs