Fix subscription liveness timeout computation to include MRP backoff. #25593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
fix-subscription-liveness-timeout-computation
branch
from
f2fb1da to
ad7dc23
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #25593: Size comparison from 82da16f to ad7dc23 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
Right now the amount of time we allow for receiving a subscription report, after the max-interval has elapsed, is computed by just multiplying our active liveness timeout by the number of MRP retries. For a typical always-active client (hence 300ms active interval) that means 1500ms. But an actual sender would do backoff in between the MRP messages, so would not actually give up within 1500ms. We should be taking that backoff into account when computing the time we allow to receive the message.
bzbarsky-apple
force-pushed
the
fix-subscription-liveness-timeout-computation
branch
from
ad7dc23 to
c058f43
Compare
|
PR #25593: Size comparison from 82da16f to c058f43 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Damian-Nordic
approved these changes
Mar 9, 2023
yunhanw-google
approved these changes
Mar 9, 2023
jtung-apple
approved these changes
Mar 9, 2023
msandstedt
approved these changes
Mar 9, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…project-chip#25593) Right now the amount of time we allow for receiving a subscription report, after the max-interval has elapsed, is computed by just multiplying our active liveness timeout by the number of MRP retries. For a typical always-active client (hence 300ms active interval) that means 1500ms. But an actual sender would do backoff in between the MRP messages, so would not actually give up within 1500ms. We should be taking that backoff into account when computing the time we allow to receive the message.
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
…project-chip#25593) Right now the amount of time we allow for receiving a subscription report, after the max-interval has elapsed, is computed by just multiplying our active liveness timeout by the number of MRP retries. For a typical always-active client (hence 300ms active interval) that means 1500ms. But an actual sender would do backoff in between the MRP messages, so would not actually give up within 1500ms. We should be taking that backoff into account when computing the time we allow to receive the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the amount of time we allow for receiving a subscription report, after the max-interval has elapsed, is computed by just multiplying our active liveness timeout by the number of MRP retries. For a typical always-active client (hence 300ms active interval) that means 1500ms.
But an actual sender would do backoff in between the MRP messages, so would not actually give up within 1500ms. We should be taking that backoff into account when computing the time we allow to receive the message.