Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove unused code in CHIPTool App #25582

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

joonhaengHeo
Copy link
Contributor

Remove unused code in Android CHIPTool.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25582: Size comparison from 1f2f882 to 8c77514

Increases (7 builds for bl602, cc13x2_26x2, telink)
platform target config section 1f2f882 8c77514 change % change
bl602 lighting-app bl602 .text 1027956 1027958 2 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 676555 676563 8 0.0
.text 589104 589112 8 0.0
telink all-clusters-app tlsr9518adk80d text 690470 690472 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 956044 956052 8 0.0
text 651540 651542 2 0.0
lighting-app-rpc tlsr9518adk80d text 705690 705692 2 0.0
lock-app tlsr9518adk80d text 609706 609708 2 0.0
pump-app tlsr9518adk80d text 587782 587784 2 0.0
Decreases (15 builds for bl702, cc13x2_26x2, efr32, esp32, k32w, nrfconnect, qpg, telink)
platform target config section 1f2f882 8c77514 change % change
bl702 lighting-app bl702 .debug_info 40860977 40860976 -1 -0.0
.text 958516 958514 -2 -0.0
bl702+rpc (read/write) 1282471 1282455 -16 -0.0
.debug_info 45487836 45487835 -1 -0.0
.text 1033858 1033856 -2 -0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 172884 172876 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1056852 1056844 -8 -0.0
.text 904192 904184 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1586058 1586050 -8 -0.0
.flash.rodata 222720 222712 -8 -0.0
m5stack (read/write) 502107 502103 -4 -0.0
.flash.rodata 251432 251428 -4 -0.0
k32w contact k32w0+release (read/write) 673704 673688 -16 -0.0
.text 574708 574692 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 804316 804312 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 773460 773456 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1153116 1153108 -8 -0.0
.text 600212 600204 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 876204 876196 -8 -0.0
text 596150 596148 -2 -0.0
lighting-app tlsr9518adk80d text 662592 662590 -2 -0.0
ota-requestor-app tlsr9518adk80d text 606660 606658 -2 -0.0
temperature-measurement-app tlsr9518adk80d text 573484 573482 -2 -0.0
thermostat tlsr9518adk80d text 597680 597678 -2 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 1f2f882 8c77514 change % change
bl602 lighting-app bl602 (read/write) 1352006 1352006 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1027956 1027958 2 0.0
bl602+rpc (read/write) 1397454 1397454 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1058892 1058892 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1191803 1191803 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30160 30160 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556803 1556803 0 0.0
.debug_aranges 134576 134576 0 0.0
.debug_frame 493364 493364 0 0.0
.debug_info 40860977 40860976 -1 -0.0
.debug_line 5294228 5294228 0 0.0
.debug_loc 3423795 3423795 0 0.0
.debug_ranges 373192 373192 0 0.0
.debug_str 3584892 3584892 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108160 108160 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 576232 576232 0 0.0
.symtab 174128 174128 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
958516 958514 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1282471 1282455 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30432 30432 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708918 1708918 0 0.0
.debug_aranges 142904 142904 0 0.0
.debug_frame 521308 521308 0 0.0
.debug_info 45487836 45487835 -1 -0.0
.debug_line 5699571 5699571 0 0.0
.debug_loc 3621810 3621810 0 0.0
.debug_ranges 397192 397192 0 0.0
.debug_str 3989088 3989088 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122368 122368 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 637557 637557 0 0.0
.symtab 192624 192624 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1033858 1033856 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 681431 681431 0 0.0
(read/write) 169664 169664 0 0.0
.bss 80788 80788 0 0.0
.data 3352 3352 0 0.0
.rodata 88527 88527 0 0.0
.text 592588 592588 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644575 644575 0 0.0
(read/write) 157456 157456 0 0.0
.bss 79988 79988 0 0.0
.data 3352 3352 0 0.0
.rodata 78399 78399 0 0.0
.text 565856 565856 0 0.0
lock-ftd LP_CC2652R7 (read only) 678375 678375 0 0.0
(read/write) 170184 170184 0 0.0
.bss 78340 78340 0 0.0
.data 3316 3316 0 0.0
.rodata 76711 76711 0 0.0
.text 601184 601184 0 0.0
lock-mtd LP_CC2652R7 (read only) 664371 664371 0 0.0
(read/write) 179348 179348 0 0.0
.bss 73500 73500 0 0.0
.data 3316 3316 0 0.0
.rodata 103523 103523 0 0.0
.text 560368 560368 0 0.0
pump-app LP_CC2652R7 (read only) 691611 691611 0 0.0
(read/write) 157692 157692 0 0.0
.bss 78316 78316 0 0.0
.data 3280 3280 0 0.0
.rodata 91083 91083 0 0.0
.text 600048 600048 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676555 676563 8 0.0
(read/write) 172884 172876 -8 -0.0
.bss 78452 78452 0 0.0
.data 3304 3304 0 0.0
.rodata 86971 86971 0 0.0
.text 589104 589112 8 0.0
shell LP_CC2652R7 (read only) 672870 672870 0 0.0
(read/write) 180296 180296 0 0.0
.bss 82860 82860 0 0.0
.data 3348 3348 0 0.0
.rodata 85430 85430 0 0.0
.text 587128 587128 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267469 0 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 0 0 0 0.0
536372 536372 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587890 587890 0 0.0
.app_xip_area 464660 464660 0 0.0
.bss 65672 65672 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591866 591866 0 0.0
.app_xip_area 463340 463340 0 0.0
.bss 70960 70960 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 552254 552254 0 0.0
.app_xip_area 434616 434616 0 0.0
.bss 60120 60120 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1031092 1031092 0 0.0
.bss 179276 179276 0 0.0
.data 2060 2060 0 0.0
.text 849736 849736 0 0.0
BRD4187C (read/write) 1013948 1013948 0 0.0
.bss 148176 148176 0 0.0
.data 2696 2696 0 0.0
.text 838480 838480 0 0.0
lock-app BRD4161A+wf200 (read/write) 1056852 1056844 -8 -0.0
.bss 150572 150572 0 0.0
.data 2068 2068 0 0.0
.text 904192 904184 -8 -0.0
window-app BRD4187C (read/write) 1130532 1130532 0 0.0
.bss 132600 132600 0 0.0
.data 2588 2588 0 0.0
.text 970748 970748 0 0.0
esp32 all-clusters-app c3devkit (read only) 1051492 1051492 0 0.0
(read/write) 1586058 1586050 -8 -0.0
.dram0.bss 77824 77824 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222720 222712 -8 -0.0
.flash.text 1051492 1051492 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1103155 1103155 0 0.0
(read/write) 502107 502103 -4 -0.0
.dram0.bss 82864 82864 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 251432 251428 -4 -0.0
.flash.text 1097771 1097771 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 673704 673688 -16 -0.0
.bss 65372 65372 0 0.0
.data 2224 2224 0 0.0
.text 574708 574692 -16 -0.0
light k32w0+release (read/write) 672748 672748 0 0.0
.bss 65036 65036 0 0.0
.data 2212 2212 0 0.0
.text 574100 574100 0 0.0
lock k32w0+release (read/write) 627164 627164 0 0.0
.bss 63108 63108 0 0.0
.data 2136 2136 0 0.0
.text 546904 546904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12164036 12164036 0 0.0
(read/write) 733448 733448 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675552 0 0.0
.dynamic 560 560 0 0.0
.got 15384 15384 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 588516 588516 0 0.0
.text 9834884 9834884 0 0.0
thermostat-no-ble arm64 (read only) 2522036 2522036 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77712 77712 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150960 150960 0 0.0
.text 2108640 2108640 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467664 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173100 1173100 0 0.0
bss 155397 155397 0 0.0
rodata 132588 132588 0 0.0
text 804316 804312 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1432896 1432896 0 0.0
bss 135137 135137 0 0.0
rodata 228640 228640 0 0.0
text 775076 775076 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118104 1118104 0 0.0
bss 154553 154553 0 0.0
rodata 109416 109416 0 0.0
text 773460 773456 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841000 841000 0 0.0
(read/write) 1763012 1763012 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189704 189704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253632 1253632 0 0.0
.debug_aranges 111464 111464 0 0.0
.debug_frame 374680 374680 0 0.0
.debug_info 27984913 27984913 0 0.0
.debug_line 3794850 3794850 0 0.0
.debug_loc 3698912 3698912 0 0.0
.debug_ranges 364816 364816 0 0.0
.debug_str 3533360 3533360 0 0.0
.heap 841000 841000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 581702 581702 0 0.0
.symtab 426048 426048 0 0.0
.text 1562280 1562280 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841808 841808 0 0.0
(read/write) 1703204 1703204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188904 188904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238965 1238965 0 0.0
.debug_aranges 110696 110696 0 0.0
.debug_frame 377016 377016 0 0.0
.debug_info 27529378 27529378 0 0.0
.debug_line 3802349 3802349 0 0.0
.debug_loc 3682113 3682113 0 0.0
.debug_ranges 362752 362752 0 0.0
.debug_str 3520482 3520482 0 0.0
.heap 841808 841808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541411 541411 0 0.0
.symtab 410960 410960 0 0.0
.text 1503280 1503280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850072 850072 0 0.0
(read/write) 1616948 1616948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180808 180808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074302 1074302 0 0.0
.debug_aranges 102904 102904 0 0.0
.debug_frame 347300 347300 0 0.0
.debug_info 22870846 22870846 0 0.0
.debug_line 3355077 3355077 0 0.0
.debug_loc 3357302 3357302 0 0.0
.debug_ranges 321312 321312 0 0.0
.debug_str 3319253 3319253 0 0.0
.heap 850072 850072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477128 477128 0 0.0
.symtab 378944 378944 0 0.0
.text 1425288 1425288 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 822296 822296 0 0.0
(read/write) 1673604 1673604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208568 208568 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076263 1076263 0 0.0
.debug_aranges 103312 103312 0 0.0
.debug_frame 349088 349088 0 0.0
.debug_info 23122949 23122949 0 0.0
.debug_line 3357139 3357139 0 0.0
.debug_loc 3381646 3381646 0 0.0
.debug_ranges 323872 323872 0 0.0
.debug_str 3338170 3338170 0 0.0
.heap 822296 822296 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480942 480942 0 0.0
.symtab 381152 381152 0 0.0
.text 1454168 1454168 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153116 1153108 -8 -0.0
.bss 99916 99916 0 0.0
.data 852 852 0 0.0
.text 600212 600204 -8 -0.0
lock-app qpg6105+debug (read/write) 1119524 1119524 0 0.0
.bss 96308 96308 0 0.0
.data 864 864 0 0.0
.text 566624 566624 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1021084 1021084 0 0.0
bss 97908 97908 0 0.0
text 690470 690472 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 956044 956052 8 0.0
bss 96960 96960 0 0.0
text 651540 651542 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860268 860268 0 0.0
bss 89124 89124 0 0.0
text 581936 581936 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876204 876196 -8 -0.0
bss 89212 89212 0 0.0
text 596150 596148 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 954900 954900 0 0.0
bss 97340 97340 0 0.0
text 662592 662590 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1023064 1023064 0 0.0
bss 98904 98904 0 0.0
text 705690 705692 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 914296 914296 0 0.0
bss 89776 89776 0 0.0
text 609706 609708 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 889068 889068 0 0.0
bss 90136 90136 0 0.0
text 606660 606658 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865804 865804 0 0.0
bss 89240 89240 0 0.0
text 587782 587784 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853064 853064 0 0.0
bss 89040 89040 0 0.0
text 578108 578108 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 848780 848780 0 0.0
bss 88900 88900 0 0.0
text 573484 573482 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 880348 880348 0 0.0
bss 90604 90604 0 0.0
text 597680 597678 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942620 942620 0 0.0
bss 99012 99012 0 0.0
text 648732 648732 0 0.0

@github-actions
Copy link

PR #25582: Size comparison from f8ef1da to 0e9c876

Full report (1 build for cc32xx)
platform target config section f8ef1da 0e9c876 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644945 644945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300224 300224 0 0.0
.debug_info 2027507 2027507 0 0.0
.debug_line 2660781 2660781 0 0.0
.debug_loc 2804731 2804731 0 0.0
.debug_ranges 283136 283136 0 0.0
.debug_str 3026077 3026077 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105921 105921 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379152 379152 0 0.0
.symtab 256848 256848 0 0.0
.text 536904 536904 0 0.0

@yunhanw-google yunhanw-google merged commit 03dc4a8 into project-chip:master Mar 10, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants