-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Remove unused code in CHIPTool App #25582
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
joonhaengHeo:remove_unused_code
Mar 10, 2023
Merged
[Android] Remove unused code in CHIPTool App #25582
yunhanw-google
merged 1 commit into
project-chip:master
from
joonhaengHeo:remove_unused_code
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25582: Size comparison from 1f2f882 to 8c77514 Increases (7 builds for bl602, cc13x2_26x2, telink)
Decreases (15 builds for bl702, cc13x2_26x2, efr32, esp32, k32w, nrfconnect, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Mar 9, 2023
yufengwangca
approved these changes
Mar 9, 2023
woody-apple
approved these changes
Mar 9, 2023
yufengwangca
force-pushed
the
remove_unused_code
branch
from
March 10, 2023 17:12
8c77514
to
0e9c876
Compare
pullapprove
bot
requested review from
amitnj,
arkq,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst and
selissia
March 10, 2023 17:13
pullapprove
bot
requested review from
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
xylophone21 and
younghak-hwang
March 10, 2023 17:13
PR #25582: Size comparison from f8ef1da to 0e9c876 Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code in Android CHIPTool.