Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take connection operations off the UI thread (#122) #25580

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

cliffamzn
Copy link
Contributor

Fixes #25554

Clicking connect in the tv-casting-app freezes the UI for a few seconds because it tries to attempt the connection on the UI thread. This puts it in an async thread so that the UI is not blocked while its trying to establish that connection.

Tested by attempting the connection and verifying it wasn't paused and still showed the right messages and connected successfully.

Clicking connect in the tv-casting-app freezes the UI for a few seconds
because it tries to attempt the connection on the UI thread. This puts
it in an async thread so that the UI is not blocked while its trying to
establish that connection.

Tested by attempting the connection and verifying it wasn't paused and
still showed the right messages and connected successfully.
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

PR #25580: Size comparison from 1f2f882 to 985bc1d

Decreases (1 build for cc32xx)
platform target config section 1f2f882 985bc1d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267469 20267468 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 1f2f882 985bc1d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267468 -1 -0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@cliffamzn cliffamzn merged commit 0b4af23 into project-chip:master Mar 10, 2023
@cliffamzn cliffamzn deleted the ui_thread branch March 13, 2023 21:01
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…ect-chip#25580)

Clicking connect in the tv-casting-app freezes the UI for a few seconds
because it tries to attempt the connection on the UI thread. This puts
it in an async thread so that the UI is not blocked while its trying to
establish that connection.

Tested by attempting the connection and verifying it wasn't paused and
still showed the right messages and connected successfully.
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
…ect-chip#25580)

Clicking connect in the tv-casting-app freezes the UI for a few seconds
because it tries to attempt the connection on the UI thread. This puts
it in an async thread so that the UI is not blocked while its trying to
establish that connection.

Tested by attempting the connection and verifying it wasn't paused and
still showed the right messages and connected successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TV-Casting - Move Android commissioning requests off the UI thread
2 participants