Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java-matter-controller] Convert Java to Kotlin Phase III #25578

Merged
merged 2 commits into from
Mar 9, 2023
Merged

[java-matter-controller] Convert Java to Kotlin Phase III #25578

merged 2 commits into from
Mar 9, 2023

Conversation

yufengwangca
Copy link
Contributor

Convert from java to kotlin phase III

Fix: Convert java matter controller test program from java version into kotlin version #25253

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

PR #25578: Size comparison from 43d45ef to 4078b56

Increases (1 build for cc32xx)
platform target config section 43d45ef 4078b56 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267468 20267469 1 0.0
Full report (1 build for cc32xx)
platform target config section 43d45ef 4078b56 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267468 20267469 1 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

swan-amazon
swan-amazon reviewed Mar 9, 2023
View reviewed changes
examples/java-matter-controller/java/src/com/matter/controller/commands/common/IPAddress.kt Outdated Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/MatterCommand.kt Outdated Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/MatterCommand.kt Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/Argument.kt Show resolved Hide resolved
examples/java-matter-controller/BUILD.gn Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/Command.kt Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/Command.kt Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/Command.kt Outdated Show resolved Hide resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/common/Command.kt Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25578: Size comparison from 1f2f882 to 2c90e31

Increases (1 build for cc32xx)
platform target config section 1f2f882 2c90e31 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267469 20267470 1 0.0
Decreases (1 build for mbed)
platform target config section 1f2f882 2c90e31 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2467664 2467600 -64 -0.0
.text 1430308 1430244 -64 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 1f2f882 2c90e31 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267470 1 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467600 -64 -0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430244 -64 -0.0

@yufengwangca yufengwangca merged commit 1e72308 into project-chip:master Mar 9, 2023
@yufengwangca yufengwangca deleted the pr/kotlin/common branch March 9, 2023 17:36
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@yufengwangca
[java-matter-controller] Convert Java to Kotlin Phase III (project-ch…
1c40b74 
…ip#25578)

* [java-matter-controller] Convert Java to Kotlin Phase III

* Address review comments
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@yufengwangca @mwswartwout
[java-matter-controller] Convert Java to Kotlin Phase III (project-ch…
945c2a6 
…ip#25578)

* [java-matter-controller] Convert Java to Kotlin Phase III

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swan-amazon swan-amazon swan-amazon approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @yunhanw-google @swan-amazon