Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #25538 #25553

Closed

Conversation

HusseinElsherbini
Copy link
Contributor

Fixes #25538
modified functions associated with writing binding entries that weren't properly returning ERROR messages

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25553: Size comparison from 3889a44 to fdad31d

Increases (1 build for bl602)
platform target config section 3889a44 fdad31d change % change
bl602 lighting-app bl602+rpc .text 1058842 1058844 2 0.0
Decreases (1 build for cc32xx)
platform target config section 3889a44 fdad31d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267388 20267386 -2 -0.0
Full report (5 builds for bl602, bl702, cc32xx)
platform target config section 3889a44 fdad31d change % change
bl602 lighting-app bl602 (read/write) 1351854 1351854 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1027908 1027908 0 0.0
bl602+rpc (read/write) 1397302 1397302 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1058842 1058844 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1190459 1190459 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1552063 1552063 0 0.0
.debug_aranges 134320 134320 0 0.0
.debug_frame 492532 492532 0 0.0
.debug_info 40616277 40616277 0 0.0
.debug_line 5283359 5283359 0 0.0
.debug_loc 3420440 3420440 0 0.0
.debug_ranges 372984 372984 0 0.0
.debug_str 3581623 3581623 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107904 107904 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 575121 575121 0 0.0
.symtab 173776 173776 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 957530 957530 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280343 1280343 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1700349 1700349 0 0.0
.debug_aranges 142560 142560 0 0.0
.debug_frame 520216 520216 0 0.0
.debug_info 45028330 45028330 0 0.0
.debug_line 5682042 5682042 0 0.0
.debug_loc 3616987 3616987 0 0.0
.debug_ranges 396760 396760 0 0.0
.debug_str 3985160 3985160 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122016 122016 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 636010 636010 0 0.0
.symtab 192096 192096 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032198 1032198 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267388 20267386 -2 -0.0
.debug_line 2659771 2659771 0 0.0
.debug_loc 2802807 2802807 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024017 3024017 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@pullapprove pullapprove bot requested a review from younghak-hwang March 7, 2023 23:35
@selissia
Copy link
Contributor

selissia commented Mar 8, 2023

Please add a more descriptive title. Something like "Update binding APIs to return errors"

@jmartinez-silabs
Copy link
Member

This pr addresses the same issue. Was open a few hours before yours

#25549

@HusseinElsherbini
Copy link
Contributor Author

Issue already fixed

@HusseinElsherbini HusseinElsherbini deleted the MATTER-1433 branch March 8, 2023 03:13
@HusseinElsherbini
Copy link
Contributor Author

Thanks for noting this.

@bzbarsky-apple
Copy link
Contributor

@HusseinElsherbini for future reference, the changes here did return an error, but not the error the spec calls for...

@HusseinElsherbini
Copy link
Contributor Author

@bzbarsky-apple thanks for the heads up, I did have one more commit to correct this behavior but its unnecessary now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants