-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Subscription resumption logic should skip subscriptions created during startup wait time #25545
Merged
jtung-apple
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/sub-resumption-skip-resuming-live-subs
Mar 9, 2023
Merged
[ICD] Subscription resumption logic should skip subscriptions created during startup wait time #25545
jtung-apple
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/sub-resumption-skip-resuming-live-subs
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during startup wait time
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 7, 2023 20:11
pullapprove
bot
requested review from
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
March 7, 2023 20:11
PR #25545: Size comparison from a566243 to 0d20187 Increases (6 builds for bl602, bl702, cc13x2_26x2, linux)
Decreases (2 builds for cc13x2_26x2)
Full report (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
|
PR #25545: Size comparison from a566243 to f3a0511 Increases (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, nrfconnect, psoc6)
Decreases (7 builds for bl702, cc13x2_26x2, efr32, psoc6)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
approved these changes
Mar 8, 2023
msandstedt
reviewed
Mar 8, 2023
bzbarsky-apple
approved these changes
Mar 8, 2023
msandstedt
approved these changes
Mar 9, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
… during startup wait time (project-chip#25545) * [ICD] Subscription resumption logic should skip subscriptions created during startup wait time
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
… during startup wait time (project-chip#25545) * [ICD] Subscription resumption logic should skip subscriptions created during startup wait time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25416 @bzbarsky-apple pointed out that if a subscription request comes in during the startup min interval wait time, the new subscription would also be persisted and the logic would create a ReadHandler object for the same subscription.
This fixes the issue by skipping resuming subscription if the SubscriptionId matches on in the ReadHandler list.