-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add some missing null checks #25535
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_AddSomeMissingNullChecks
Mar 7, 2023
Merged
[chip-tool] Add some missing null checks #25535
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_AddSomeMissingNullChecks
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Mar 7, 2023
cliffamzn
approved these changes
Mar 7, 2023
yunhanw-google
approved these changes
Mar 7, 2023
PR #25535: Size comparison from 4203370 to 49ce038 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
49ce038
to
1b9fc10
Compare
PR #25535: Size comparison from 4f53be4 to 1b9fc10 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds a few missing null checks once some memory has been allocated with
Platform::MemoryCalloc
into theComplexArgument
header ofchip-tool
.