Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool] Add some missing null checks #25535

Conversation

vivien-apple
Copy link
Contributor

Problem

This PR adds a few missing null checks once some memory has been allocated with Platform::MemoryCalloc into the ComplexArgument header of chip-tool.

@vivien-apple vivien-apple self-assigned this Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25535: Size comparison from 4203370 to 49ce038

Increases (1 build for cc32xx)
platform target config section 4203370 49ce038 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2026706 20267068 1 0.0
Full report (1 build for cc32xx)
platform target config section 4203370 49ce038 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300028 300028 0 0.0
.debug_info 2026706 20267068 1 0.0
.debug_line 2659698 2659698 0 0.0
.debug_loc 2802749 2802749 0 0.0
.debug_ranges 282952 282952 0 0.0
.debug_str 3023892 3023892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_AddSomeMissingNullChecks branch from 49ce038 to 1b9fc10 Compare March 7, 2023 19:50
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25535: Size comparison from 4f53be4 to 1b9fc10

Decreases (1 build for cc32xx)
platform target config section 4f53be4 1b9fc10 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267388 20267387 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 4f53be4 1b9fc10 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267388 20267387 -1 -0.0
.debug_line 2659771 2659771 0 0.0
.debug_loc 2802807 2802807 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024017 3024017 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@vivien-apple vivien-apple merged commit 1bdeb63 into project-chip:master Mar 7, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants