-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Adds fix for #25500 #25529
[Silabs] Adds fix for #25500 #25529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better in that at least now it will not obviously violate the spec, but it looks like we can never represent "this network supports both WPA and WPA2" in this setup. Can the underlying platform data, before we convert to wfx_sec_t, represent that? If so, we need a followup to propagate that through properly...
PR #25529: Size comparison from 2a6f4ef to cd52243 Increases (6 builds for bl702, cc13x2_26x2, psoc6)
Decreases (3 builds for bl602, cc13x2_26x2, qpg)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Now that I have understood the requirement properly, I will make the necessary changes in the translation in the follow-up PR. |
PR #25529: Size comparison from 2a6f4ef to 8e44c18 Increases above 0.2%:
Increases (7 builds for bl702, nrfconnect, psoc6)
Decreases (8 builds for bl602, cc32xx, efr32, nrfconnect)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
e8106c2
to
14e0fa1
Compare
PR #25529: Size comparison from 43d45ef to 14e0fa1 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25529: Size comparison from ecd60f3 to 14983f3 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
* Adds fix for project-chip#25500 * Adds missed code change in header of function * Adds build fix for SiWx917
* Adds fix for project-chip#25500 * Adds missed code change in header of function * Adds build fix for SiWx917
Adds fixes for #25500 by changing the argument for
SlWiFiDriver::ConvertSecuritytype