Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Support random pincode #25511

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

joonhaengHeo
Copy link
Contributor

OpenCommissioning is not possible with random pinCode on Android Platform, we modified it to randomly generate pinCode if pinCode is not set.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25511: Size comparison from 69ec3ea to 68d6611

Decreases (1 build for cc32xx)
platform target config section 69ec3ea 68d6611 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267068 20267066 -2 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 69ec3ea 68d6611 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300028 300028 0 0.0
.debug_info 20267068 20267066 -2 -0.0
.debug_line 2659698 2659698 0 0.0
.debug_loc 2802749 2802749 0 0.0
.debug_ranges 282952 282952 0 0.0
.debug_str 3023892 3023892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467600 2467600 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430244 1430244 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25511: Size comparison from 3889a44 to bd5e55d

Decreases (1 build for cc32xx)
platform target config section 3889a44 bd5e55d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267388 20267387 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 3889a44 bd5e55d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267388 20267387 -1 -0.0
.debug_line 2659771 2659771 0 0.0
.debug_loc 2802807 2802807 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024017 3024017 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@pullapprove pullapprove bot requested a review from younghak-hwang March 7, 2023 23:35
@andy31415 andy31415 merged commit a8242ff into project-chip:master Mar 20, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Support random pincode in Android

* Restyle

* Add @nullable

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants