-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Some CHIP_ERROR returned values are ignored #25486
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_ChipErrorNotHandled
Mar 7, 2023
Merged
[chip-tool] Some CHIP_ERROR returned values are ignored #25486
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_ChipErrorNotHandled
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25486: Size comparison from 7e7b7af to 30398ad Increases (2 builds for cc32xx, qpg)
Decreases (1 build for linux)
Full report (5 builds for cc32xx, linux, qpg)
|
cliffamzn
approved these changes
Mar 6, 2023
vivien-apple
force-pushed
the
ChipTool_ChipErrorNotHandled
branch
from
March 6, 2023 19:59
30398ad
to
2a85cf8
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock and
kkasperczyk-no
March 6, 2023 20:00
pullapprove
bot
requested review from
ksperling-apple,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
March 6, 2023 20:00
bzbarsky-apple
approved these changes
Mar 6, 2023
yunhanw-google
approved these changes
Mar 6, 2023
PR #25486: Size comparison from 1d8d73f to 2a85cf8 Increases (6 builds for bl702, psoc6, qpg)
Decreases (5 builds for bl602, cc32xx, cyw30739, linux)
Full report (26 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, psoc6, qpg)
|
vivien-apple
force-pushed
the
ChipTool_ChipErrorNotHandled
branch
from
March 7, 2023 10:58
2a85cf8
to
e4ebcc0
Compare
PR #25486: Size comparison from fc0e4a2 to e4ebcc0 Increases (9 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, cc13x2_26x2, cyw30739, esp32, linux, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some
CHIP_ERROR
returned values are ignored inchip-tool
. This PR adds handling for them, or in the case ofWebSocketServer::Send
removed the returned value since it does not seems useful.