Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the efr32 lock app to store credentials by type #25465

Merged

Conversation

mykrupp
Copy link
Contributor

@mykrupp mykrupp commented Mar 3, 2023

Addresses #21656 and #25082

Tested on efr32 platform, ran through cert tests DRLK 2.9 and 2.11. Checked nvm storage still works.

@mykrupp mykrupp force-pushed the efr32_lock_multiple_credentials branch from c2fc95b to b8c6859 Compare March 3, 2023 18:16
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

PR #25465: Size comparison from 0573c94 to b8c6859

Full report (1 build for cc32xx)
platform target config section 0573c94 b8c6859 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262928 20262928 0 0.0
.debug_line 2657820 2657820 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@mykrupp mykrupp force-pushed the efr32_lock_multiple_credentials branch from b8c6859 to 5ae8e9f Compare March 6, 2023 01:14
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

PR #25465: Size comparison from 32fb896 to 5ae8e9f

Increases (1 build for cc32xx)
platform target config section 32fb896 5ae8e9f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262927 20262928 1 0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 32fb896 5ae8e9f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262927 20262928 1 0.0
.debug_line 2657822 2657822 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167844 1167844 0 0.0
bss 143423 143423 0 0.0
rodata 136352 136352 0 0.0
text 808236 808236 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112880 1112880 0 0.0
bss 142579 142579 0 0.0
rodata 113196 113196 0 0.0
text 777384 777384 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372848 1372848 0 0.0
bss 105902 105902 0 0.0
rodata 213740 213740 0 0.0
text 767724 767724 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151820 1151820 0 0.0
.bss 99812 99812 0 0.0
.data 852 852 0 0.0
.text 598916 598916 0 0.0
lock-app qpg6105+debug (read/write) 1118868 1118868 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565968 565968 0 0.0

@andy31415 andy31415 merged commit 9c0e79f into project-chip:master Mar 6, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…5465)

* Allow the efr32 lock app to store credentials by type

* Restyled by clang-format

* update 917 platform

* Restyled by whitespace

* fix typo

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants