-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Fix systemd services race when running tests #25460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Tizen QEMU image tests are launched by the serial-getty service after auto login to root. However, there is no explicit before/after ordering between serial-getty service and ISO image mounting service. On slow systems (e.g. CI) it might happen that the serial-getty is started before ISO image mount target. This results in tests being not launched... This commit adds explicit run ordering between serial-getty and multi-user target, which shall guarantee that tests will be launched after CHIP ISO image is mounted and all Tizen services are ready.
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 3, 2023 12:27
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
March 3, 2023 12:27
PR #25460: Size comparison from af3fdc5 to ac9cdc8 Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
msandstedt
approved these changes
Mar 3, 2023
PR #25460: Size comparison from 32fb896 to 729b51a Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25460: Size comparison from 32fb896 to ab517fb Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 6, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
) * [Tizen] Fix systemd services race when running tests On the Tizen QEMU image tests are launched by the serial-getty service after auto login to root. However, there is no explicit before/after ordering between serial-getty service and ISO image mounting service. On slow systems (e.g. CI) it might happen that the serial-getty is started before ISO image mount target. This results in tests being not launched... This commit adds explicit run ordering between serial-getty and multi-user target, which shall guarantee that tests will be launched after CHIP ISO image is mounted and all Tizen services are ready. * Do not run runner script in the interactive mode * Add libncurses5 (required by GDB) to Tizen docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests on Tizen QEMU image are launched by the serial-getty service after auto login to root. However, there is no explicit before/after ordering between serial-getty service and the ISO image mounting service. On slow systems (e.g. CI) it might happen that the serial-getty is started before ISO image mount target. This results in tests being not launched...
Changes
guestfish
commandslibncurses5
to Tizen docker imageTesting
Tested locally, that the
[email protected]
is always run aftermulti-user.target
:before:
after: