-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: move Wi-Fi initializition out of Matter stack Initializition #25455
Merged
yufengwangca
merged 3 commits into
project-chip:master
from
wqx6:esp32/move_out_wifi_init
Mar 7, 2023
Merged
ESP32: move Wi-Fi initializition out of Matter stack Initializition #25455
yufengwangca
merged 3 commits into
project-chip:master
from
wqx6:esp32/move_out_wifi_init
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25455: Size comparison from af3fdc5 to 524f688 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
717b50b
to
0e3fbb8
Compare
PR #25455: Size comparison from 32fb896 to 0e3fbb8 Full report (1 build for cc32xx)
|
chshu
reviewed
Mar 6, 2023
PR #25455: Size comparison from 32fb896 to 6a4d910 Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Mar 6, 2023
PR #25455: Size comparison from a7cc2cf to 3e3bc72 Increases (9 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, qpg, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chshu
approved these changes
Mar 7, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#25455) * ESP32: move Wi-Fi initializing out of Matter stack Initializing * review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to move Wi-Fi initializing out of Matter stack initializing so that we can determine whether to initialize Wi-Fi stack according to a soft flag instead of the config macro parameter.
Changes
Test
Tested commissioning for all the examples on ESP32-C2
Tested commissioning for lighting-app example on ESP32-H2