[java-matter-controller] Convert from java to kotlin phase I #25384

yufengwangca · 2023-03-01T00:14:08Z

Currently, java-matter-controller is written in Java, we have request from our internal team to convert it to kotlin to better align with our internal development and easy to integrate with our internal utility libs written in kotlin, such as TLV writter and reader, etc...

Fix: Convert java matter controller test program from java version into kotlin version #25253

github-actions · 2023-03-01T00:42:06Z

PR #25384: Size comparison from 20c65a2 to d1ca1cc

Decreases (1 build for cc32xx)

platform	target	config	section	`20c65a2`	`d1ca1cc`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262893	20262892	-1	-0.0

Full report (2 builds for cc32xx, mbed)

platform	target	config	section	`20c65a2`	`d1ca1cc`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643465	643465	0	0.0
			(read/write)	203688	203688	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197088	197088	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930167	930167	0	0.0
			.debug_aranges	87336	87336	0	0.0
			.debug_frame	300024	300024	0	0.0
			.debug_info	20262893	20262892	-1	-0.0
			.debug_line	2657205	2657205	0	0.0
			.debug_loc	2799993	2799993	0	0.0
			.debug_ranges	282240	282240	0	0.0
			.debug_str	3023883	3023883	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105929	105929	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	378514	378514	0	0.0
			.symtab	256560	256560	0	0.0
			.text	535412	535412	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2467448	2467448	0	0.0
			.bss	215804	215804	0	0.0
			.data	5880	5880	0	0.0
			.text	1430092	1430092	0	0.0

examples/java-matter-controller/README.md

github-actions · 2023-03-01T03:21:23Z

PR #25384: Size comparison from e75d35a to 43b9663

Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`e75d35a`	`43b9663`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	643465	643465
			(read/write)	203688	203688
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197088	197088
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930167	930167
			.debug_aranges	87336	87336
			.debug_frame	300024	300024
			.debug_info	20262892	20262892
			.debug_line	2657205	2657205
			.debug_loc	2799993	2799993
			.debug_ranges	282240	282240
			.debug_str	3023883	3023883
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105929	105929
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	378514	378514
			.symtab	256560	256560
			.text	535412	535412
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2467448	2467448
			.bss	215804	215804
			.data	5880	5880
			.text	1430092	1430092
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4
			(read/write)	1167796	1167796
			bss	143423	143423
			rodata	136352	136352
			text	808180	808180
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4
			(read/write)	1112816	1112816
			bss	142579	142579
			rodata	113196	113196
			text	777324	777324
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4
			(read/write)	1372880	1372880
			bss	105902	105902
			rodata	213740	213740
			text	767752	767752
qpg	lighting-app	qpg6105+debug	(read/write)	1151668	1151668
			.bss	99804	99804
			.data	852	852
			.text	598764	598764
	lock-app	qpg6105+debug	(read/write)	1118876	1118876
			.bss	96292	96292
			.data	864	864
			.text	565976	565976

examples/java-matter-controller/java/src/com/matter/controller/Main.kt

...s/java-matter-controller/java/src/com/matter/controller/commands/discover/DiscoverCommand.kt

...ontroller/java/src/com/matter/controller/commands/discover/DiscoverCommissionablesCommand.kt

...-controller/java/src/com/matter/controller/commands/discover/DiscoverCommissionersCommand.kt

github-actions · 2023-03-02T08:53:30Z

PR #25384: Size comparison from 1a1d0c3 to 1209b25

Full report (1 build for cc32xx)

platform	target	config	section	`1a1d0c3`	`1209b25`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	643465	643465
			(read/write)	203688	203688
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197088	197088
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930213	930213
			.debug_aranges	87336	87336
			.debug_frame	300024	300024
			.debug_info	20262923	20262923
			.debug_line	2657815	2657815
			.debug_loc	2800026	2800026
			.debug_ranges	282240	282240
			.debug_str	3023883	3023883
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105929	105929
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	378514	378514
			.symtab	256560	256560
			.text	535412	535412

...ontroller/java/src/com/matter/controller/commands/discover/DiscoverCommissionablesCommand.kt

github-actions · 2023-03-02T17:43:02Z

PR #25384: Size comparison from 0062c5d to b586bb5

Increases (1 build for cc32xx)

platform	target	config	section	`0062c5d`	`b586bb5`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262927	20262928	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`0062c5d`	`b586bb5`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262927	20262928	1
			.debug_line	`2657820`	`2657820`	0
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

github-actions · 2023-03-02T18:34:48Z

PR #25384: Size comparison from 0062c5d to c800ef7

Increases (1 build for cc32xx)

platform	target	config	section	`0062c5d`	`c800ef7`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20262927	20262928	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`0062c5d`	`c800ef7`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643465	643465	0
			(read/write)	203688	203688	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197088	197088	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930213	930213	0
			.debug_aranges	87336	87336	0
			.debug_frame	300024	300024	0
			.debug_info	20262927	20262928	1
			.debug_line	`2657820`	`2657820`	0
			.debug_loc	2800026	2800026	0
			.debug_ranges	282240	282240	0
			.debug_str	3023883	3023883	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105929	105929	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	378514	378514	0
			.symtab	256560	256560	0
			.text	535412	535412	0

…-chip#25384) * [java-matter-controller] Convert from java to kotlin phase I * Address review comments * Move constants outside the class instance

github-actions bot added examples github workflows labels Mar 1, 2023

pullapprove bot requested review from vijs, vivien-apple, woody-apple and xylophone21 March 1, 2023 00:14

pullapprove bot added review - pending examples github workflows and removed examples github workflows labels Mar 1, 2023

yunhanw-google reviewed Mar 1, 2023

View reviewed changes

examples/java-matter-controller/README.md Outdated Show resolved Hide resolved

g-coppock suggested changes Mar 1, 2023

View reviewed changes

andy31415 reviewed Mar 1, 2023

View reviewed changes

...ontroller/java/src/com/matter/controller/commands/discover/DiscoverCommissionablesCommand.kt Outdated Show resolved Hide resolved

andy31415 reviewed Mar 1, 2023

View reviewed changes

...-controller/java/src/com/matter/controller/commands/discover/DiscoverCommissionersCommand.kt Outdated Show resolved Hide resolved

andy31415 approved these changes Mar 2, 2023

View reviewed changes

yufengwangca added 2 commits March 2, 2023 08:33

[java-matter-controller] Convert from java to kotlin phase I

ca32f60

Address review comments

b586bb5

g-coppock suggested changes Mar 2, 2023

View reviewed changes

...ontroller/java/src/com/matter/controller/commands/discover/DiscoverCommissionablesCommand.kt Outdated Show resolved Hide resolved

...ontroller/java/src/com/matter/controller/commands/discover/DiscoverCommissionablesCommand.kt Outdated Show resolved Hide resolved

Move constants outside the class instance

c800ef7

g-coppock approved these changes Mar 3, 2023

View reviewed changes

andy31415 added the fast track label Mar 3, 2023

yufengwangca merged commit 0573c94 into project-chip:master Mar 3, 2023

yufengwangca deleted the pr/kotlin/convert branch March 3, 2023 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[java-matter-controller] Convert from java to kotlin phase I #25384

[java-matter-controller] Convert from java to kotlin phase I #25384

yufengwangca commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

[java-matter-controller] Convert from java to kotlin phase I #25384

[java-matter-controller] Convert from java to kotlin phase I #25384

Conversation

yufengwangca commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

github-actions bot commented Mar 2, 2023