Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to create TLV context tags fron enum class values. #25381

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

We shouldn't be making all consumers use to_underlying.

We shouldn't be making all consumers use to_underlying.
@github-actions
Copy link

PR #25381: Size comparison from 7ce9d78 to e805153

Increases (1 build for cc32xx)
platform target config section 7ce9d78 e805153 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 930167 930213 46 0.0
.debug_info 20262891 20262923 32 0.0
.debug_line 2657205 2657808 603 0.0
.debug_loc 2799993 2800026 33 0.0
Full report (1 build for cc32xx)
platform target config section 7ce9d78 e805153 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930213 46 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262891 20262923 32 0.0
.debug_line 2657205 2657808 603 0.0
.debug_loc 2799993 2800026 33 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023623 3023623 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378494 378494 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

src/lib/core/TLVTags.h Outdated Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) March 1, 2023 14:41
@bzbarsky-apple bzbarsky-apple merged commit e434c6a into project-chip:master Mar 1, 2023
@bzbarsky-apple bzbarsky-apple deleted the context-tag-enums branch March 1, 2023 17:41
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…oject-chip#25381)

* Make it easier to create TLV context tags fron enum class values.

We shouldn't be making all consumers use to_underlying.

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants