-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Implement Thread SRP service remove #25371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25371: Size comparison from de6f9a1 to 8ba6849 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
dh79pyun
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
PR #25371: Size comparison from c1810b6 to 88ab50b Full report (1 build for cc32xx)
|
PR #25371: Size comparison from c1810b6 to a690238 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
May 4, 2023 14:51
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 4, 2023 14:51
PR #25371: Size comparison from 5ff1818 to c17ac71 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 4, 2023
woody-apple
force-pushed
the
tizen-thread
branch
from
June 24, 2023 21:50
c17ac71
to
8ca866e
Compare
PR #25371: Size comparison from a41398b to 8ca866e Increases (6 builds for bl602, esp32, nrfconnect, telink)
Decreases (14 builds for bl602, bl702, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is no implementation for Thread SRP services remove on Tizen. This PR implements such functionality using Tizen thread API available since Tizen 7.0.
Changes
_RemoveSrpService()
,_RemoveInvalidSrpServices()
and_InvalidateAllSrpServices()
thread_srp_client_register_service_full()
API for registering service which allows to export TXT entriesTesting
CI will test potential build failures. Functionality tested locally on Thread-enabled Tizen device.