Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JNI error in tv-app #25331

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix JNI error in tv-app #25331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7c2271
Change default passcode returned from account login cluster. Move use…
amitnj Feb 27, 2023
a9515dc
Restyled by clang-format
restyled-commits Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...p/android/App/content-app/src/main/java/com/example/contentapp/CommandResponseHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ private CommandResponseHolder() {
setResponseValue(
Clusters.AccountLogin.Id,
Clusters.AccountLogin.Commands.GetSetupPIN.ID,
"{\"0\":\"12345678\"}");
"{\"0\":\"20202021\"}");
};

public static CommandResponseHolder getInstance() {
Expand Down
10 changes: 6 additions & 4 deletions examples/tv-app/android/java/ContentAppCommandDelegate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,13 @@ void ContentAppCommandDelegate::InvokeCommand(CommandHandlerInterface::HandlerCo
env->ExceptionDescribe();
chrisdecenzo marked this conversation as resolved.
Show resolved Hide resolved
env->ExceptionClear();
FormatResponseData(handlerContext, "{\"value\":{}}");
return;
}
JniUtfString respStr(env, resp);
ChipLogProgress(Zcl, "ContentAppCommandDelegate::InvokeCommand got response %s", respStr.c_str());
FormatResponseData(handlerContext, respStr.c_str());
else
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
{
JniUtfString respStr(env, resp);
ChipLogProgress(Zcl, "ContentAppCommandDelegate::InvokeCommand got response %s", respStr.c_str());
FormatResponseData(handlerContext, respStr.c_str());
}
env->DeleteLocalRef(resp);
}
else
Expand Down