Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on -Wconversion in some tests, shell, jsontlv. #25326

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Turn on -Wconversion in some tests, shell, jsontlv. #25326

merged 2 commits into from
Feb 26, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions
Copy link

PR #25326: Size comparison from 265d55c to 4f789a8

Increases (1 build for cc32xx)
platform target config section 265d55c 4f789a8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256906 20256908 2 0.0
Full report (1 build for cc32xx)
platform target config section 265d55c 4f789a8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256906 20256908 2 0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

arkq
arkq reviewed Feb 25, 2023
View reviewed changes
src/inet/BasicPacketFilters.h Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #25326: Size comparison from 265d55c to 5a05f88

Decreases (1 build for cc32xx)
platform target config section 265d55c 5a05f882 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 642609 -72 -0.0
.debug_info 20256906 20256037 -869 -0.0
.debug_line 2656086 2655900 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_str 3023369 3023188 -181 -0.0
.rodata 105769 105761 -8 -0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0
Full report (1 build for cc32xx)
platform target config section 265d55c 5a05f882 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642609 -72 -0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256906 20256037 -869 -0.0
.debug_line 2656086 2655900 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023188 -181 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105761 -8 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0

@github-actions
Copy link

PR #25326: Size comparison from 072efd5 to ea9255e

Increases (1 build for qpg)
platform target config section 072efd5 ea9255e change % change
qpg lighting-app qpg6105+debug (read/write) 1151284 1151292 8 0.0
.text 598380 598388 8 0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 072efd5 ea9255e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642609 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256038 0 0.0
.debug_line 2655900 2655900 0 0.0
.debug_loc 2797195 2797195 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534724 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467096 2467096 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429740 1429740 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151284 1151292 8 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598380 598388 8 0.0
lock-app qpg6105+debug (read/write) 1118500 1118500 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565600 565600 0 0.0

@github-actions
Copy link

PR #25326: Size comparison from 072efd5 to 30bf368

Full report (2 builds for cc32xx, mbed)
platform target config section 072efd5 30bf368 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642609 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256038 0 0.0
.debug_line 2655900 2655900 0 0.0
.debug_loc 2797195 2797195 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534724 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467096 2467096 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429740 1429740 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 3b80154 into project-chip:master Feb 26, 2023
@bzbarsky-apple bzbarsky-apple deleted the various-Wconversion branch February 26, 2023 15:17
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Turn on -Wconversion in some tests, shell, jsontlv. (project-chip#25326)
2aa0b78 
* Turn on -Wconversion in some tests, shell, jsontlv.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq left review comments

@cliffamzn cliffamzn cliffamzn approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@emargolis emargolis emargolis approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
inet lib review - approved shell support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @arkq @emargolis @vivien-apple @cliffamzn