Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for example to disable the TEST_SETUP_PARAMS flag #25322

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

cliffamzn
Copy link
Contributor

Documentation indicates that the CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS can be dangerous to include in production use cases (see config/standalone/CHIPProjectConfig.h)

We should disable it where necessary

Documentation indicates that the `CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS`
can be dangerous to include in production use cases (see
`config/standalone/CHIPProjectConfig.h`)

We should disable it where necessary
@github-actions
Copy link

PR #25322: Size comparison from 265d55c to 1c9cd3c

Full report (1 build for cc32xx)
platform target config section 265d55c 1c9cd3c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256906 20256906 0 0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit e97ca93 into project-chip:master Feb 27, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…#25322)

Documentation indicates that the `CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS`
can be dangerous to include in production use cases (see
`config/standalone/CHIPProjectConfig.h`)

We should disable it where necessary
@cliffamzn cliffamzn deleted the optimize_tv branch June 29, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants