Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZAP template] Add to flake8 in workflow and fix python files (part #25193) #25303

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[ZAP template] Add to flake8 in workflow and fix python files (part #25193) #25303

merged 1 commit into from
Feb 24, 2023

Conversation

DamMicSzm
Copy link
Contributor

This pull request is a part of #25193 ( part fix python files and ZAP template )

Problem

Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.

Changes

Fix all python files where linter find problem and update template. Add to check with flake8.

Testing

CI will test and maybe some another manual testing

@github-actions
Copy link

PR #25303: Size comparison from 61cf6f2 to 373bf38

Increases (1 build for cc32xx)
platform target config section 61cf6f2 373bf38 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257009 20257010 1 0.0
Full report (1 build for cc32xx)
platform target config section 61cf6f2 373bf38 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257009 20257010 1 0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-zap-template branch from 373bf38 to 725dec1 Compare February 24, 2023 11:34
@github-actions
Copy link

PR #25303: Size comparison from 61cf6f2 to 725dec1

Increases (1 build for cc32xx)
platform target config section 61cf6f2 725dec1f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257009 20257011 2 0.0
Full report (1 build for cc32xx)
platform target config section 61cf6f2 725dec1f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257009 20257011 2 0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-zap-template branch from 725dec1 to 90623ad Compare February 24, 2023 15:28
@DamMicSzm DamMicSzm force-pushed the flake8-fix-zap-template branch from 90623ad to 57251ca Compare February 24, 2023 15:53
@github-actions
Copy link

PR #25303: Size comparison from ad5dc95 to 57251ca

Increases (3 builds for bl602, bl702, cc32xx)
platform target config section ad5dc95 57251ca change % change
bl602 lighting-app bl602 (read/write) 1349814 1349822 8 0.0
.text 1026032 1026034 2 0.0
bl702 lighting-app bl702 .debug_info 40596342 40596344 2 0.0
.text 955378 955382 4 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256906 20256907 1 0.0
Decreases (1 build for bl602)
platform target config section ad5dc95 57251ca change % change
bl602 lighting-app bl602+rpc .text 1056968 1056966 -2 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section ad5dc95 57251ca change % change
bl602 lighting-app bl602 (read/write) 1349814 1349822 8 0.0
.bss 94674 94674 0 0.0
.data 9752 9752 0 0.0
.text 1026032 1026034 2 0.0
bl602+rpc (read/write) 1395238 1395238 0 0.0
.bss 102722 102722 0 0.0
.data 10144 10144 0 0.0
.text 1056968 1056966 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1188171 1188171 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4080 4080 0 0.0
.debug_abbrev 1551744 1551744 0 0.0
.debug_aranges 134248 134248 0 0.0
.debug_frame 492212 492212 0 0.0
.debug_info 40596342 40596344 2 0.0
.debug_line 5278033 5278033 0 0.0
.debug_loc 3416695 3416695 0 0.0
.debug_ranges 372032 372032 0 0.0
.debug_str 3579936 3579936 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107744 107744 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574257 574257 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 955378 955382 4 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278375 1278375 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4624 4624 0 0.0
.debug_abbrev 1699953 1699953 0 0.0
.debug_aranges 142488 142488 0 0.0
.debug_frame 519900 519900 0 0.0
.debug_info 45008322 45008322 0 0.0
.debug_line 5676794 5676794 0 0.0
.debug_loc 3613417 3613417 0 0.0
.debug_ranges 395808 395808 0 0.0
.debug_str 3983473 3983473 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635274 635274 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030406 1030406 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256906 20256907 1 0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12116244 12116244 0 0.0
(read/write) 732616 732616 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674896 674896 0 0.0
.dynamic 560 560 0 0.0
.got 15368 15368 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 586900 586900 0 0.0
.text 9790692 9790692 0 0.0
thermostat-no-ble arm64 (read only) 2515868 2515868 0 0.0
(read/write) 145064 145064 0 0.0
.bss 56328 56328 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150552 150552 0 0.0
.text 2103248 2103248 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118540 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565640 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7cd2add into project-chip:master Feb 24, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@DamMicSzm
[ZAP template] Add to flake8 in workflow and fix python files (projec…
e31857b 
…t-chip#25303)
@DamMicSzm DamMicSzm deleted the flake8-fix-zap-template branch July 13, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamMicSzm @andy31415 @bzbarsky-apple