Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Feature Flag to Enable/Disable Global EventList Attribute #25294

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Implemented Feature Flag to Enable/Disable Global EventList Attribute #25294

merged 4 commits into from
Feb 25, 2023

Conversation

emargolis
Copy link
Contributor

The feature is disabled by default. To enable global EventList attribute use feature flag as follow:
gn gen out/host --args='enable_eventlist_attribute=true'

Note to reviewers:
To minimize complexity and implementation of this feature flag, this PR doesn't change *.zap, *.matter and auto generated files, which still list and implement logic associated with EventList attribute. However, this logic will never be used if enable_eventlist_attribute == false.

Fixes #25231

@github-actions
Copy link

PR #25294: Size comparison from 7775bec to 38d1433

Decreases (1 build for cc32xx)
platform target config section 7775bec 38d1433 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 642609 -72 -0.0
.debug_info 20257010 20256141 -869 -0.0
.debug_line 2656183 2655997 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_str 3023459 3023278 -181 -0.0
.rodata 105769 105761 -8 -0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0
Full report (1 build for cc32xx)
platform target config section 7775bec 38d1433 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642609 -72 -0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257010 20256141 -869 -0.0
.debug_line 2656183 2655997 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023278 -181 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105761 -8 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix TestAttributePathExpandIterator too....

@emargolis emargolis force-pushed the emargolis/feature/global-eventlist-feature-flag branch from 38d1433 to b956617 Compare February 24, 2023 20:58
@github-actions github-actions bot added the tests label Feb 24, 2023
@github-actions
Copy link

PR #25294: Size comparison from 31da720 to 9a1d868

Increases (8 builds for bl702, cc13x2_26x2)
platform target config section 31da720 9a1d868 change % change
bl702 lighting-app bl702 .debug_ranges 372032 372112 80 0.0
bl702+rpc .debug_ranges 395808 395888 80 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 170704 170760 56 0.0
lock-ftd LP_CC2652R7 (read/write) 171848 171896 48 0.0
lock-mtd LP_CC2652R7 (read/write) 180324 180364 40 0.0
pump-app LP_CC2652R7 (read/write) 159364 159412 48 0.0
pump-controller-app LP_CC2652R7 (read/write) 174548 174588 40 0.0
shell LP_CC2652R7 (read/write) 181360 181416 56 0.0
Decreases (20 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section 31da720 9a1d868 change % change
bl602 lighting-app bl602 (read/write) 1349822 1349802 -20 -0.0
.text 1026034 1026032 -2 -0.0
bl602+rpc (read/write) 1395238 1395234 -4 -0.0
bl702 lighting-app bl702 .debug_info 40596344 40595629 -715 -0.0
.debug_line 5278033 5277830 -203 -0.0
.debug_loc 3416695 3416492 -203 -0.0
.debug_str 3579936 3579755 -181 -0.0
.text 955382 955380 -2 -0.0
bl702+rpc (read/write) 1278375 1278119 -256 -0.0
.debug_info 45008324 45007688 -636 -0.0
.debug_line 5676794 5676591 -203 -0.0
.debug_loc 3613417 3613214 -203 -0.0
.debug_str 3983473 3983292 -181 -0.0
.text 1030410 1030154 -256 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680367 680311 -56 -0.0
.rodata 88335 88319 -16 -0.0
.text 591716 591676 -40 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643503 643455 -48 -0.0
.rodata 78199 78191 -8 -0.0
.text 564984 564944 -40 -0.0
lock-ftd LP_CC2652R7 (read only) 676591 676543 -48 -0.0
.text 599592 599544 -48 -0.0
lock-mtd LP_CC2652R7 (read only) 663371 663331 -40 -0.0
.text 559528 559488 -40 -0.0
pump-app LP_CC2652R7 (read only) 689819 689771 -48 -0.0
.text 598416 598368 -48 -0.0
pump-controller-app LP_CC2652R7 (read only) 674771 674731 -40 -0.0
.rodata 86811 86803 -8 -0.0
.text 587480 587448 -32 -0.0
shell LP_CC2652R7 (read only) 671782 671726 -56 -0.0
.rodata 85230 85222 -8 -0.0
.text 586240 586192 -48 -0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 642609 -72 -0.0
.debug_info 20256908 20256037 -871 -0.0
.debug_line 2656086 2655900 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_str 3023369 3023188 -181 -0.0
.rodata 105769 105761 -8 -0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0
linux chip-tool-ipv6only arm64 (read only) 12127908 12123636 -4272 -0.0
.rodata 586948 586900 -48 -0.0
.text 9802196 9797972 -4224 -0.0
thermostat-no-ble arm64 (read only) 2515868 2515364 -504 -0.0
.rodata 150552 150528 -24 -0.0
.text 2103248 2102768 -480 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2467168 2467096 -72 -0.0
.text 1429812 1429740 -72 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1167432 1167376 -56 -0.0
rodata 136196 136188 -8 -0.0
text 807976 807928 -48 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1112452 1112396 -56 -0.0
rodata 113040 113032 -8 -0.0
text 777120 777068 -52 -0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1372532 1372476 -56 -0.0
rodata 213584 213576 -8 -0.0
text 767556 767508 -48 -0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151292 -48 -0.0
.text 598436 598388 -48 -0.0
lock-app qpg6105+debug (read/write) 1118540 1118500 -40 -0.0
.text 565640 565600 -40 -0.0
Full report (20 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section 31da720 9a1d868 change % change
bl602 lighting-app bl602 (read/write) 1349822 1349802 -20 -0.0
.bss 94674 94674 0 0.0
.data 9752 9752 0 0.0
.text 1026034 1026032 -2 -0.0
bl602+rpc (read/write) 1395238 1395234 -4 -0.0
.bss 102722 102722 0 0.0
.data 10144 10144 0 0.0
.text 1056968 1056968 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1188171 1188171 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4080 4080 0 0.0
.debug_abbrev 1551744 1551744 0 0.0
.debug_aranges 134248 134248 0 0.0
.debug_frame 492212 492212 0 0.0
.debug_info 40596344 40595629 -715 -0.0
.debug_line 5278033 5277830 -203 -0.0
.debug_loc 3416695 3416492 -203 -0.0
.debug_ranges 372032 372112 80 0.0
.debug_str 3579936 3579755 -181 -0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107744 107744 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574257 574257 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 955382 955380 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278375 1278119 -256 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4624 4624 0 0.0
.debug_abbrev 1699953 1699953 0 0.0
.debug_aranges 142488 142488 0 0.0
.debug_frame 519900 519900 0 0.0
.debug_info 45008324 45007688 -636 -0.0
.debug_line 5676794 5676591 -203 -0.0
.debug_loc 3613417 3613214 -203 -0.0
.debug_ranges 395808 395888 80 0.0
.debug_str 3983473 3983292 -181 -0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635274 635274 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030410 1030154 -256 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680367 680311 -56 -0.0
(read/write) 170704 170760 56 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88335 88319 -16 -0.0
.text 591716 591676 -40 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643503 643455 -48 -0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78199 78191 -8 -0.0
.text 564984 564944 -40 -0.0
lock-ftd LP_CC2652R7 (read only) 676591 676543 -48 -0.0
(read/write) 171848 171896 48 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76519 76519 0 0.0
.text 599592 599544 -48 -0.0
lock-mtd LP_CC2652R7 (read only) 663371 663331 -40 -0.0
(read/write) 180324 180364 40 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103363 103363 0 0.0
.text 559528 559488 -40 -0.0
pump-app LP_CC2652R7 (read only) 689819 689771 -48 -0.0
(read/write) 159364 159412 48 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 90923 90923 0 0.0
.text 598416 598368 -48 -0.0
pump-controller-app LP_CC2652R7 (read only) 674771 674731 -40 -0.0
(read/write) 174548 174588 40 0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86811 86803 -8 -0.0
.text 587480 587448 -32 -0.0
shell LP_CC2652R7 (read only) 671782 671726 -56 -0.0
(read/write) 181360 181416 56 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85230 85222 -8 -0.0
.text 586240 586192 -48 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642609 -72 -0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256908 20256037 -871 -0.0
.debug_line 2656086 2655900 -186 -0.0
.debug_loc 2797535 2797195 -340 -0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023188 -181 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105761 -8 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256224 -32 -0.0
.text 534788 534724 -64 -0.0
linux chip-tool-ipv6only arm64 (read only) 12127908 12123636 -4272 -0.0
(read/write) 732808 732808 0 0.0
.bss 34280 34280 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674936 674936 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 586948 586900 -48 -0.0
.text 9802196 9797972 -4224 -0.0
thermostat-no-ble arm64 (read only) 2515868 2515364 -504 -0.0
(read/write) 145064 145064 0 0.0
.bss 56328 56328 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150552 150528 -24 -0.0
.text 2103248 2102768 -480 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467096 -72 -0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429740 -72 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167432 1167376 -56 -0.0
bss 143423 143423 0 0.0
rodata 136196 136188 -8 -0.0
text 807976 807928 -48 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112452 1112396 -56 -0.0
bss 142579 142579 0 0.0
rodata 113040 113032 -8 -0.0
text 777120 777068 -52 -0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372532 1372476 -56 -0.0
bss 105886 105886 0 0.0
rodata 213584 213576 -8 -0.0
text 767556 767508 -48 -0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151292 -48 -0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598388 -48 -0.0
lock-app qpg6105+debug (read/write) 1118540 1118500 -40 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565600 -40 -0.0

@andy31415 andy31415 merged commit b89e83b into project-chip:master Feb 25, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@emargolis
Implemented Feature Flag to Enable/Disable Global EventList Attribute (…
24e56b8 
…project-chip#25294)

* Implemented Feature Flag to Enable/Disable Global EventList Attribute

* Added ifdefs to the TestAttributePathExpandIterator.cpp test

* Updated YAML tests

* ZAP REGEN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to Implement Feature Flag for EventList Global Attribute Feature
3 participants
@emargolis @andy31415 @bzbarsky-apple