Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Add to flake8 in workflow and fix python files (part #25193) #25277

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

DamMicSzm
Copy link
Contributor

This pull request is a part of #25193 ( part fix python files in nrfconnect )

Problem

Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.

Changes

Fix all python files in nrfconnect where linter find problem. Adding nrfconnect to check with flake8.

Testing

CI will test and maybe some another manual testing

@github-actions
Copy link

PR #25277: Size comparison from 7e728bc to 1c70716

Decreases (1 build for cc32xx)
platform target config section 7e728bc 1c70716 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20249763 20249762 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 7e728bc 1c70716 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642569 642569 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930138 930138 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299764 299764 0 0.0
.debug_info 20249763 20249762 -1 -0.0
.debug_line 2655140 2655140 0 0.0
.debug_loc 2795460 2795460 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3018033 3018033 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377761 377761 0 0.0
.symtab 256256 256256 0 0.0
.text 534628 534628 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466856 2466856 0 0.0
.bss 215780 215780 0 0.0
.data 5880 5880 0 0.0
.text 1429500 1429500 0 0.0

@github-actions
Copy link

PR #25277: Size comparison from 61cf6f2 to 0ab347b

Full report (2 builds for cc32xx, mbed)
platform target config section 61cf6f2 0ab347b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257009 20257009 0 0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-nrfconnect branch from 0ab347b to 3a6a869 Compare March 1, 2023 09:31
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25277: Size comparison from eff5773 to 3a6a869

Full report (1 build for cc32xx)
platform target config section eff5773 3a6a869 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262893 0 0.0
.debug_line 2657207 2657207 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-nrfconnect branch from 3a6a869 to 37a6807 Compare March 8, 2023 11:40
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

PR #25277: Size comparison from 536a0d9 to 37a6807

Full report (1 build for cc32xx)
platform target config section 536a0d9 37a6807 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267387 20267387 0 0.0
.debug_line 2659771 2659771 0 0.0
.debug_loc 2802807 2802807 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024017 3024017 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@yufengwangca yufengwangca merged commit e5c1a3b into project-chip:master Mar 13, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@DamMicSzm DamMicSzm deleted the flake8-fix-nrfconnect branch July 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants