-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Add to flake8 in workflow and fix python files (part #25193) #25277
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-nrfconnect
Mar 13, 2023
Merged
[nrfconnect] Add to flake8 in workflow and fix python files (part #25193) #25277
yufengwangca
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-nrfconnect
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
February 23, 2023 13:41
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 23, 2023 13:41
PR #25277: Size comparison from 7e728bc to 1c70716 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Feb 23, 2023
DamMicSzm
force-pushed
the
flake8-fix-nrfconnect
branch
from
February 24, 2023 09:20
1c70716
to
0ab347b
Compare
PR #25277: Size comparison from 61cf6f2 to 0ab347b Full report (2 builds for cc32xx, mbed)
|
DamMicSzm
force-pushed
the
flake8-fix-nrfconnect
branch
from
March 1, 2023 09:31
0ab347b
to
3a6a869
Compare
PR #25277: Size comparison from eff5773 to 3a6a869 Full report (1 build for cc32xx)
|
DamMicSzm
force-pushed
the
flake8-fix-nrfconnect
branch
from
March 8, 2023 11:40
3a6a869
to
37a6807
Compare
PR #25277: Size comparison from 536a0d9 to 37a6807 Full report (1 build for cc32xx)
|
yufengwangca
approved these changes
Mar 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a part of #25193 ( part fix python files in nrfconnect )
Problem
Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.
Changes
Fix all python files in nrfconnect where linter find problem. Adding nrfconnect to check with flake8.
Testing
CI will test and maybe some another manual testing