Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestDiscovery.yaml by enabling a few more steps #25276

Merged
merged 2 commits into from
Feb 23, 2023
+136 −66
Merged

Update TestDiscovery.yaml by enabling a few more steps #25276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f1bbe1
Update TestDiscovery.yaml by enabling a few more steps
vivien-apple Feb 22, 2023
4a68abe
Update generated tests code
vivien-apple Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/all-clusters-app/linux/include/CHIPProjectAppConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@

// Allows app options (ports) to be configured on launch of app
#define CHIP_DEVICE_ENABLE_PORT_PARAMS 1

// Expose the device type in the advertisement for CI testing.
#define CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONABLE_DEVICE_TYPE 1
17 changes: 4 additions & 13 deletions src/app/tests/suites/TestDiscovery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ config:
defaultValue: 32769
deviceType:
type: int16u
defaultValue: 5
defaultValue: 65535

tests:
- label: "Stop target device"
Expand Down Expand Up @@ -105,23 +105,19 @@ tests:

- label: "Check Hostname"
PICS: "(MCORE.COM.WIFI || MCORE.COM.ETH) && !MCORE.COM.THR"
# On macOS the hostname is the device name and because of it this test is disabled for now.
disabled: true
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
values:
- name: "hostName"
constraints:
minLength: 12
maxLength: 12
maxLength: 16
isUpperCase: true
isHexString: true

- label: "Check Hostname"
PICS: "(!MCORE.COM.WIFI && !MCORE.COM.ETH) && MCORE.COM.THR"
# On macOS the hostname is the device name and because of it this test is disabled for now.
disabled: true
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand Down Expand Up @@ -165,8 +161,6 @@ tests:
value: vendorId

- label: "Check Device Type ID (_T)"
# The device type is not broadcasted by the accessory under CI.
disabled: true
PICS: MCORE.SC.DEVTYPE_SUBTYPE
cluster: "DiscoveryCommands"
command: "FindCommissionableByDeviceType"
Expand Down Expand Up @@ -217,6 +211,7 @@ tests:
values:
- name: "mrpRetryIntervalIdle"
constraints:
minValue: 0
maxValue: 3600000

- label: "Optional TXT key for MRP Sleepy Active Interval (SAI)"
Expand All @@ -227,6 +222,7 @@ tests:
values:
- name: "mrpRetryIntervalActive"
constraints:
minValue: 0
maxValue: 3600000

- label: "TXT key for commissioning mode (CM)"
Expand All @@ -238,18 +234,13 @@ tests:
value: 1

- label: "Optional TXT key for device type (DT)"
disabled: true
PICS: MCORE.SC.DT_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
values:
- name: "deviceType"
value: deviceType
constraints:
# The specification says this is a number expressed as <ddd>, but it seems like it can goes
# up to 0xBFFF (49151).
maxValue: 999

- label: "Optional TXT key for device name (DN)"
PICS: MCORE.SC.DN_KEY
Expand Down
2 changes: 1 addition & 1 deletion src/app/tests/suites/certification/ci-pics-values
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,7 @@ MCORE.SC.DEVTYPE_SUBTYPE=1
MCORE.SC.VP_KEY=1
MCORE.SC.DT_KEY=1
MCORE.SC.DN_KEY=1
MCORE.SC.RI_KEY=1
MCORE.SC.RI_KEY=0
MCORE.SC.PH_KEY=1
MCORE.SC.PI_KEY=1
MCORE.SC.EXTENDED_DISCOVERY=1
Expand Down
Loading