Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make event timestamps follow the spec more closely. #25266

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Make event timestamps follow the spec more closely. #25266

merged 1 commit into from
Feb 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 23, 2023 •
edited
Loading

  • We were using "monotonic timestamp" as a synonym for "time since boot", but nothing actually guarantees that. Switch to measuring time since server init for "time since boot". This is the spec fix.
  • Get rid of CHIP_CONFIG_EVENT_LOGGING_UTC_TIMESTAMPS. Just always try the realtime clock before falling back on since-boot timestamps. Since this might change which timestamps we use dynamically, make sure that our consecutive timestamps are in fact the same type when doing delta encoding.
  • Improve tests to test both since-boot and realtime timestamps.

@pullapprove pullapprove bot requested a review from yufengwangca February 23, 2023 03:14
@pullapprove pullapprove bot requested a review from yunhanw-google February 23, 2023 03:14
@github-actions
Copy link

PR #25266: Size comparison from 19fbda3 to 36cfa7e

Increases (2 builds for cc32xx, mbed)
platform target config section 19fbda3 36cfa7e change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642569 642689 120 0.0
(read/write) 203664 203672 8 0.0
.bss 197064 197072 8 0.0
.debug_frame 299764 299768 4 0.0
.debug_info 20249761 20250840 1079 0.0
.debug_line 2655140 2655389 249 0.0
.debug_loc 2795460 2795907 447 0.0
.debug_str 3018033 3018715 682 0.0
.strtab 377761 377805 44 0.0
.text 534628 534748 120 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2466856 2466984 128 0.0
.bss 215780 215788 8 0.0
.text 1429500 1429628 128 0.0
Decreases (1 build for cc32xx)
platform target config section 19fbda3 36cfa7e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 930138 930133 -5 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 19fbda3 36cfa7e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642569 642689 120 0.0
(read/write) 203664 203672 8 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197072 8 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930138 930133 -5 -0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299764 299768 4 0.0
.debug_info 20249761 20250840 1079 0.0
.debug_line 2655140 2655389 249 0.0
.debug_loc 2795460 2795907 447 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3018033 3018715 682 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377761 377805 44 0.0
.symtab 256256 256256 0 0.0
.text 534628 534748 120 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466856 2466984 128 0.0
.bss 215780 215788 8 0.0
.data 5880 5880 0 0.0
.text 1429500 1429628 128 0.0

@bzbarsky-apple
Make event timestamps follow the spec more closely.
1f02c01 
* We were using "monotonic timestamp" as a synonym for "time since boot", but
  nothing actually guarantees that.  Switch to measuring time since server init
  for "time since boot".  This is the spec fix.
* Get rid of CHIP_CONFIG_EVENT_LOGGING_UTC_TIMESTAMPS.  Just always try the
  realtime clock before falling back on since-boot timestamps.  Since this might
  change which timestamps we use dynamically, make sure that our consecutive
  timestamps are in fact the same type when doing delta encoding.
* Improve tests to test both since-boot and realtime timestamps.
@bzbarsky-apple bzbarsky-apple force-pushed the event-management-fix-timing branch from 36cfa7e to 1f02c01 Compare February 23, 2023 05:37
@github-actions
Copy link

PR #25266: Size comparison from 7e728bc to 1f02c01

Increases (1 build for cc32xx)
platform target config section 7e728bc 1f02c01 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642569 642689 120 0.0
(read/write) 203664 203672 8 0.0
.bss 197064 197072 8 0.0
.debug_frame 299764 299768 4 0.0
.debug_info 20249763 20250842 1079 0.0
.debug_line 2655140 2655389 249 0.0
.debug_loc 2795460 2795907 447 0.0
.debug_str 3018033 3018715 682 0.0
.strtab 377761 377805 44 0.0
.text 534628 534748 120 0.0
Decreases (1 build for cc32xx)
platform target config section 7e728bc 1f02c01 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 930138 930133 -5 -0.0
Full report (1 build for cc32xx)
platform target config section 7e728bc 1f02c01 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642569 642689 120 0.0
(read/write) 203664 203672 8 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197072 8 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930138 930133 -5 -0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299764 299768 4 0.0
.debug_info 20249763 20250842 1079 0.0
.debug_line 2655140 2655389 249 0.0
.debug_loc 2795460 2795907 447 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3018033 3018715 682 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377761 377805 44 0.0
.symtab 256256 256256 0 0.0
.text 534628 534748 120 0.0

@andy31415 andy31415 merged commit 7c77e8e into project-chip:master Feb 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the event-management-fix-timing branch February 23, 2023 16:54
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Make event timestamps follow the spec more closely. (project-chip#25266)
adebe3d 
* We were using "monotonic timestamp" as a synonym for "time since boot", but
  nothing actually guarantees that.  Switch to measuring time since server init
  for "time since boot".  This is the spec fix.
* Get rid of CHIP_CONFIG_EVENT_LOGGING_UTC_TIMESTAMPS.  Just always try the
  realtime clock before falling back on since-boot timestamps.  Since this might
  change which timestamps we use dynamically, make sure that our consecutive
  timestamps are in fact the same type when doing delta encoding.
* Improve tests to test both since-boot and realtime timestamps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app core examples lib review - approved test driver tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @yunhanw-google @jmartinez-silabs @andy31415