Check for too-large events before we modify our buffer state. #25257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could end up in a situation where an INFO event that fit into the DEBUG buffer but did not fit into the INFO buffer would get written to the buffer, and possibly evict some other events, but then we would error out from LogEventPrivate, and leave ourselves in an inconsistent state. The fix is to do the "this event fits in all the buffers that it might need to fit in" check before we start modifying any state.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
yunhanw-google
approved these changes
Feb 22, 2023
|
PR #25257: Size comparison from c6cadc8 to c06519d Increases (8 builds for bl702, cc13x2_26x2, cc32xx)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
Full report (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
|
jmartinez-silabs
approved these changes
Feb 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#25257) We could end up in a situation where an INFO event that fit into the DEBUG buffer but did not fit into the INFO buffer would get written to the buffer, and possibly evict some other events, but then we would error out from LogEventPrivate, and leave ourselves in an inconsistent state. The fix is to do the "this event fits in all the buffers that it might need to fit in" check before we start modifying any state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could end up in a situation where an INFO event that fit into the DEBUG buffer but did not fit into the INFO buffer would get written to the buffer, and possibly evict some other events, but then we would error out from LogEventPrivate, and leave ourselves in an inconsistent state.
The fix is to do the "this event fits in all the buffers that it might need to fit in" check before we start modifying any state.