-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Defined default MRP retry intervals for the platform #25244
Merged
andy31415
merged 1 commit into
project-chip:master
from
kkasperczyk-no:mrp_values_change
Feb 22, 2023
Merged
[nrfconnect] Defined default MRP retry intervals for the platform #25244
andy31415
merged 1 commit into
project-chip:master
from
kkasperczyk-no:mrp_values_change
Feb 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock and
ksperling-apple
February 22, 2023 12:41
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tecimovic and
tehampson
February 22, 2023 12:41
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
February 22, 2023 12:41
markaj-nordic
approved these changes
Feb 22, 2023
examples/lighting-app/nrfconnect/main/include/CHIPProjectConfig.h
Outdated
Show resolved
Hide resolved
kkasperczyk-no
force-pushed
the
mrp_values_change
branch
from
February 22, 2023 12:55
b9a6221
to
f2431f0
Compare
The nrfconnect platform requires some custom MRP retry intervals that are proven by tests to work for Wi-Fi and Thread. Added defining MRP retry values to the nrfconnect platform code.
kkasperczyk-no
force-pushed
the
mrp_values_change
branch
from
February 22, 2023 12:56
f2431f0
to
024ea93
Compare
PR #25244: Size comparison from cad990f to 024ea93 Decreases (3 builds for cc32xx, qpg)
Full report (3 builds for cc32xx, qpg)
|
Damian-Nordic
approved these changes
Feb 22, 2023
andy31415
approved these changes
Feb 22, 2023
LuDuda
approved these changes
Feb 22, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…oject-chip#25244) The nrfconnect platform requires some custom MRP retry intervals that are proven by tests to work for Wi-Fi and Thread. Added defining MRP retry values to the nrfconnect platform code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nrfconnect platform requires some custom MRP retry intervals that are proven by tests to work for Wi-Fi and Thread.
Added defining MRP retry values to the nrfconnect platform code.