Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fixed window app setting value issue. #25243

Merged

Conversation

kkasperczyk-no
Copy link
Contributor

Setting the position in other states than moving or open/close is not correctly handled, what leads to setting null position and bricking the algorithm, so changing the position is not possible anymore

Added properly handling the case that position doesn't change.

Setting the position in other states than moving or open/close
is not correctly handled, what leads to setting null position
and bricking the algorithm, so changing the position is not
possible anymore

Added properly handling the case that position doesn't change.
@github-actions
Copy link

PR #25243: Size comparison from cad990f to 830b853

Full report (1 build for cc32xx)
platform target config section cad990f 830b853 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254060 0 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017876 3017876 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@yufengwangca yufengwangca merged commit 788552b into project-chip:master Feb 22, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Setting the position in other states than moving or open/close
is not correctly handled, what leads to setting null position
and bricking the algorithm, so changing the position is not
possible anymore

Added properly handling the case that position doesn't change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants