Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-WNCV-2.2] Fix WindowCover ConfigStatus initialization #25200

Merged

Conversation

mkardous-silabs
Copy link
Contributor

Description

ConfigStatus was not being correctly based on the feature map.

Test

Manual test to make sure ConfigStatus matches the FeatureMap

@github-actions
Copy link

PR #25200: Size comparison from 66d35fb to dcfa138

Full report (1 build for cc32xx)
platform target config section 66d35fb dcfa138 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930533 930533 0 0.0
.debug_aranges 87392 87392 0 0.0
.debug_frame 300100 300100 0 0.0
.debug_info 20256519 20256519 0 0.0
.debug_line 2656075 2656075 0 0.0
.debug_loc 2796964 2796964 0 0.0
.debug_ranges 281712 281712 0 0.0
.debug_str 3018892 3018892 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377598 377598 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@pullapprove pullapprove bot requested a review from nivi-apple February 20, 2023 20:06
@bzbarsky-apple bzbarsky-apple merged commit 885e854 into project-chip:master Feb 20, 2023
@mkardous-silabs mkardous-silabs deleted the fix/window_config branch February 20, 2023 22:47
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants