Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Rename silabs config to be inline with coding standards #25162

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[Silabs] Rename silabs config to be inline with coding standards #25162

merged 2 commits into from
Feb 17, 2023

Conversation

mkardous-silabs
Copy link
Contributor

Description

  • Rename silabs config form SILABSConfig to SilabsConfig
  • Fix configuration manager init

Tests

  • Built application manually to make sure it works

@github-actions
Copy link

PR #25162: Size comparison from 0edb83a to bd4dfa6

Increases (1 build for qpg)
platform target config section 0edb83a bd4dfa6 change % change
qpg lighting-app qpg6105+debug (read/write) 1150644 1150652 8 0.0
.text 597740 597748 8 0.0
Decreases (3 builds for bl702, cc32xx)
platform target config section 0edb83a bd4dfa6 change % change
bl702 lighting-app bl702 .debug_info 40702887 40702886 -1 -0.0
.text 954746 954744 -2 -0.0
bl702+rpc .debug_info 45118314 45118313 -1 -0.0
.text 1032156 1032154 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20361460 20361459 -1 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section 0edb83a bd4dfa6 change % change
bl602 lighting-app bl602 (read/write) 1348762 1348762 0 0.0
.bss 94690 94690 0 0.0
.data 9736 9736 0 0.0
.text 1025144 1025144 0 0.0
bl602+rpc (read/write) 1394186 1394186 0 0.0
.bss 102738 102738 0 0.0
.data 10128 10128 0 0.0
.text 1056078 1056078 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1187331 1187331 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4064 4064 0 0.0
.debug_abbrev 1556113 1556113 0 0.0
.debug_aranges 134400 134400 0 0.0
.debug_frame 492608 492608 0 0.0
.debug_info 40702887 40702886 -1 -0.0
.debug_line 5284354 5284354 0 0.0
.debug_loc 3417979 3417979 0 0.0
.debug_ranges 372096 372096 0 0.0
.debug_str 3576735 3576735 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107568 107568 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573628 573628 0 0.0
.symtab 173504 173504 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 954746 954744 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280479 1280479 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1704359 1704359 0 0.0
.debug_aranges 142640 142640 0 0.0
.debug_frame 520372 520372 0 0.0
.debug_info 45118314 45118313 -1 -0.0
.debug_line 5683397 5683397 0 0.0
.debug_loc 3614933 3614933 0 0.0
.debug_ranges 395872 395872 0 0.0
.debug_str 3980272 3980272 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122208 122208 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634692 634692 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032156 1032154 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87472 87472 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20361460 20361459 -1 -0.0
.debug_line 2661258 2661258 0 0.0
.debug_loc 2797585 2797585 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3020435 3020435 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12052756 12052756 0 0.0
(read/write) 729224 729224 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585396 585396 0 0.0
.text 9736804 9736804 0 0.0
thermostat-no-ble arm64 (read only) 2516220 2516220 0 0.0
(read/write) 145096 145096 0 0.0
.bss 56312 56312 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2102752 2102752 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150644 1150652 8 0.0
.bss 99820 99820 0 0.0
.data 852 852 0 0.0
.text 597740 597748 8 0.0
lock-app qpg6105+debug (read/write) 1118204 1118204 0 0.0
.bss 96316 96316 0 0.0
.data 864 864 0 0.0
.text 565304 565304 0 0.0

@yufengwangca yufengwangca merged commit cd6f9d4 into project-chip:master Feb 17, 2023
@mkardous-silabs mkardous-silabs deleted the fix/rot_adv branch February 17, 2023 21:30
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 24, 2023
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#603: Cherry-Pick - [Silabs] Rename silabs c…
b81187f 
…onfig to be inline with coding standards (project-chip#25162)

Merge in WMN_TOOLS/matter from cherry-pick/fix_rotating_id to RC_1.1.0-1.1

Squashed commit of the following:

commit 12775af310c3869ed5731d43074398fb17902e24
Author: Mathieu Kardous <[email protected]>
Date:   Mon Feb 20 12:09:07 2023 -0500

    Update naming in SiWx917DeviceDataProvider

commit 3aae81320842f1c3cf3d9f3db59ac35e58b129cc
Author: mkardous-silabs <[email protected]>
Date:   Fri Feb 17 16:25:58 2023 -0500

    [Silabs] Rename silabs config to be inline with coding standards (project-chip#25162)

    * Fix Configuration Manager init

    * rename SILABSConfig to SilabsConfig to be inline with coding standards
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@mkardous-silabs
[Silabs] Rename silabs config to be inline with coding standards (pro…
70890e1 
…ject-chip#25162)

* Fix Configuration Manager init

* rename SILABSConfig to SilabsConfig to be inline with coding standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @yufengwangca @bzbarsky-apple