-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a linux contact sensor #25161
Merged
Merged
Add a linux contact sensor #25161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
force-pushed
the
linux_sensor
branch
from
February 17, 2023 17:44
bc5938d
to
ad33d28
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock and
kkasperczyk-no
February 17, 2023 18:15
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 17, 2023 18:15
bzbarsky-apple
approved these changes
Feb 17, 2023
PR #25161: Size comparison from 0edb83a to 0233a06 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25161: Size comparison from c56a2a7 to 60581d6 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
…mplex unfortunately
bzbarsky-apple
requested changes
Feb 21, 2023
PR #25161: Size comparison from c56a2a7 to bf69b1f Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Feb 21, 2023
PR #25161: Size comparison from c56a2a7 to c7340a8 Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Feb 21, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* A linux contact sensor app * Fix project config * Also add occupancy sensing UI * Restyle * Added TODO for boolean state - no impl yet though * Remove unnedded init override * Copy over networking logic form all clusters. This seems unusually complex unfortunately * Use bridge as an example of network commissioning * Update HAL comment with linking the boolean state issue * Restyle * Ensure port parameters are enabled in the contact sensor app --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linux compilation for the contact sensor.
The control can be done via UI. I have built it using:
Includes adding a UI window for boolean states and UI-based control of the state value.