-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI support for controlling the light app #25160
Merged
andy31415
merged 8 commits into
project-chip:master
from
andy31415:light_control_support
Feb 22, 2023
Merged
Add UI support for controlling the light app #25160
andy31415
merged 8 commits into
project-chip:master
from
andy31415:light_control_support
Feb 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25160: Size comparison from 0edb83a to cadf48e Decreases (2 builds for bl702, cc32xx)
Full report (12 builds for bl602, bl702, cc32xx, k32w, linux, qpg)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
February 17, 2023 21:54
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple and
woody-apple
February 17, 2023 21:54
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
February 17, 2023 21:54
PR #25160: Size comparison from 0edb83a to 229fa55 Increases (18 builds for bl702, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg, telink)
Decreases (17 builds for bl602, bl702, cc32xx, cyw30739, k32w, psoc6, qpg, telink)
Full report (30 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #25160: Size comparison from c56a2a7 to 27998f3 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Feb 21, 2023
bzbarsky-apple
approved these changes
Feb 22, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Control support for light app * Use the light on-off-server to drive UI logic: make it seem like a on off command * Make level control also work with the server values * Restyle * Undo an unneeded edit * Remove initializer - static should be 0-filled anyway * Update static variable to file local instead of function-local --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the UI actually be able to toggle the light on/off and update brightness.
Tested by pairing the app with a controller and seeing the controller updating based on UI updates.