Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config-data] Add a new DefineBitmaps category to config-data.yaml to… #25150

Merged

Conversation

vivien-apple
Copy link
Contributor

… filter which bitmaps are allowed to generates #define

Problem

Similarly to the WeakEnums, this adds a DefineBitmaps allow list for bitmaps.
Some parts of the SDK (not much) relies on the generated #define instead of using the generated enum classes.

… filter which bitmaps are allowed to generates #define
@github-actions
Copy link

PR #25150: Size comparison from dba34b6 to 4632758

Full report (1 build for cc32xx)
platform target config section dba34b6 4632758 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642097 642097 0 0.0
(read/write) 203784 203784 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197184 197184 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934765 934765 0 0.0
.debug_aranges 87528 87528 0 0.0
.debug_frame 300436 300436 0 0.0
.debug_info 20376093 20376093 0 0.0
.debug_line 2662014 2662014 0 0.0
.debug_loc 2794558 2794558 0 0.0
.debug_ranges 281544 281544 0 0.0
.debug_str 3014681 3014681 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105729 105729 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376442 376442 0 0.0
.symtab 256016 256016 0 0.0
.text 534248 534248 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit ffd72c8 into project-chip:master Feb 17, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
… filter which bitmaps are allowed to generates #define (project-chip#25150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants