Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenes: emberAfCurrentCommand and emberAfCurrentEndpoint removal #25136

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Scenes: emberAfCurrentCommand and emberAfCurrentEndpoint removal #25136

merged 3 commits into from
Feb 17, 2023

Conversation

lpbeliveau-silabs
Copy link
Contributor

Removed use of emberAfCurrentCommand and emberAfCurrentEndpoint in scenes.cpp

@bzbarsky-apple bzbarsky-apple force-pushed the feature/scene_remove_af_command_endpoint branch from 1934f2e to ee09025 Compare February 17, 2023 01:29
@github-actions github-actions bot added the app label Feb 17, 2023
@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) February 17, 2023 02:17
@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited
Loading

PR #25136: Size comparison from 5f058f9 to 7ef35a3

Increases (6 builds for cc13x2_26x2, psoc6, telink)
platform target config section 5f058f9 7ef35a3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171500 171612 112 0.1
shell LP_CC2652R7 (read/write) 182316 182412 96 0.1
psoc6 all-clusters cy8ckit_062s2_43012 .debug_str 3524066 3524072 6 0.0
.strtab 579749 579755 6 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_str 3510523 3510529 6 0.0
.strtab 540171 540177 6 0.0
light cy8ckit_062s2_43012 .debug_info 22937592 22937593 1 0.0
telink light-switch-app tlsr9518adk80d text 592656 592658 2 0.0
Decreases (18 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, linux, nrfconnect, psoc6, telink)
platform target config section 5f058f9 7ef35a3 change % change
bl602 lighting-app bl602+rpc .text 1056046 1056042 -4 -0.0
bl702 lighting-app bl702 .debug_info 40645881 40645880 -1 -0.0
.text 954766 954764 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679707 679595 -112 -0.0
.text 591012 590900 -112 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643083 642987 -96 -0.0
.text 564544 564448 -96 -0.0
shell LP_CC2652R7 (read only) 670962 670866 -96 -0.0
.text 585520 585424 -96 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330255 20330254 -1 -0.0
efr32 window-app BRD4187C (read/write) 1138616 1138472 -144 -0.0
.text 976568 976424 -144 -0.0
linux thermostat-no-ble arm64 (read only) 2517204 2516660 -544 -0.0
.text 2103680 2103136 -544 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164032 1163904 -128 -0.0
text 806180 806056 -124 -0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1369324 1369196 -128 -0.0
text 765944 765816 -128 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1109636 1109508 -128 -0.0
text 775700 775572 -128 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1760268 1760140 -128 -0.0
.debug_abbrev 1253002 1252941 -61 -0.0
.debug_frame 374656 374652 -4 -0.0
.debug_info 28049351 28048633 -718 -0.0
.debug_line 3793551 3793380 -171 -0.0
.debug_loc 3686388 3686363 -25 -0.0
.debug_ranges 363312 363288 -24 -0.0
.symtab 425248 425216 -32 -0.0
.text 1559368 1559240 -128 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1701084 1700940 -144 -0.0
.debug_abbrev 1238589 1238528 -61 -0.0
.debug_frame 377092 377088 -4 -0.0
.debug_info 27596786 27596070 -716 -0.0
.debug_line 3802017 3801846 -171 -0.0
.debug_loc 3670002 3669977 -25 -0.0
.debug_ranges 361280 361256 -24 -0.0
.symtab 410512 410480 -32 -0.0
.text 1501000 1500856 -144 -0.0
lock cy8ckit_062s2_43012 .debug_info 2318102 23181025 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1015412 1015212 -200 -0.0
text 686390 686186 -204 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 951392 951184 -208 -0.0
text 648208 648004 -204 -0.0
lighting-app tlsr9518adk80d text 658712 658710 -2 -0.0
thermostat tlsr9518adk80d (read/write) 875840 875640 -200 -0.0
text 594278 594080 -198 -0.0
Full report (41 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5f058f9 7ef35a3 change % change
bl602 lighting-app bl602 (read/write) 1349102 1349102 0 0.0
.bss 94834 94834 0 0.0
.data 9736 9736 0 0.0
.text 1025366 1025366 0 0.0
bl602+rpc (read/write) 1394270 1394270 0 0.0
.bss 102882 102882 0 0.0
.data 10128 10128 0 0.0
.text 1056046 1056042 -4 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187451 1187451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1551468 1551468 0 0.0
.debug_aranges 134384 134384 0 0.0
.debug_frame 492440 492440 0 0.0
.debug_info 40645881 40645880 -1 -0.0
.debug_line 5282334 5282334 0 0.0
.debug_loc 3414273 3414273 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3575307 3575307 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107552 107552 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574057 574057 0 0.0
.symtab 173584 173584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
954766 954764 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1280607 1280607 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1699936 1699936 0 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520188 520188 0 0.0
.debug_info 45055034 45055034 0 0.0
.debug_line 5681330 5681330 0 0.0
.debug_loc 3611135 3611135 0 0.0
.debug_ranges 395960 395960 0 0.0
.debug_str 3978811 3978811 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122192 122192 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635116 635116 0 0.0
.symtab 192048 192048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032160 1032160 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679707 679595 -112 -0.0
(read/write) 171500 171612 112 0.1
.bss 80900 80900 0 0.0
.data 3384 3384 0 0.0
.rodata 88379 88379 0 0.0
.text 591012 590900 -112 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643083 642987 -96 -0.0
(read/write) 157600 157600 0 0.0
.bss 80100 80100 0 0.0
.data 3384 3384 0 0.0
.rodata 78219 78219 0 0.0
.text 564544 564448 -96 -0.0
lock-ftd LP_CC2652R7 (read only) 676103 676103 0 0.0
(read/write) 172464 172464 0 0.0
.bss 78348 78348 0 0.0
.data 3312 3312 0 0.0
.rodata 76735 76735 0 0.0
.text 598888 598888 0 0.0
lock-mtd LP_CC2652R7 (read only) 662547 662547 0 0.0
(read/write) 181276 181276 0 0.0
.bss 73604 73604 0 0.0
.data 3312 3312 0 0.0
.rodata 103315 103315 0 0.0
.text 558752 558752 0 0.0
pump-app LP_CC2652R7 (read only) 689179 689179 0 0.0
(read/write) 160116 160116 0 0.0
.bss 78308 78308 0 0.0
.data 3276 3276 0 0.0
.rodata 90915 90915 0 0.0
.text 597784 597784 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674379 674379 0 0.0
(read/write) 175036 175036 0 0.0
.bss 78428 78428 0 0.0
.data 3300 3300 0 0.0
.rodata 86923 86923 0 0.0
.text 586976 586976 0 0.0
shell LP_CC2652R7 (read only) 670962 670866 -96 -0.0
(read/write) 182316 182412 96 0.1
.bss 82972 82972 0 0.0
.data 3380 3380 0 0.0
.rodata 85130 85130 0 0.0
.text 585520 585424 -96 -0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930151 930151 0 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20330255 20330254 -1 -0.0
.debug_line 2658243 2658243 0 0.0
.debug_loc 2791404 2791404 0 0.0
.debug_ranges 281600 281600 0 0.0
.debug_str 3015052 3015052 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 0 0 0 0.0
534036 534036 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586054 586054 0 0.0
.app_xip_area 462816 462816 0 0.0
.bss 65680 65680 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589770 589770 0 0.0
.app_xip_area 461236 461236 0 0.0
.bss 70968 70968 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550986 550986 0 0.0
.app_xip_area 433260 433260 0 0.0
.bss 60216 60216 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1040696 1040696 0 0.0
.bss 181608 181608 0 0.0
.data 2044 2044 0 0.0
.text 857020 857020 0 0.0
BRD4187C (read/write) 1137496 1137496 0 0.0
.bss 133288 133288 0 0.0
.data 2532 2532 0 0.0
.text 977080 977080 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067256 1067256 0 0.0
.bss 153128 153128 0 0.0
.data 2052 2052 0 0.0
.text 912052 912052 0 0.0
window-app BRD4187C (read/write) 1138616 1138472 -144 -0.0
.bss 134880 134880 0 0.0
.data 2572 2572 0 0.0
.text 976568 976424 -144 -0.0
k32w contact k32w0+release (read/write) 669764 669764 0 0.0
.bss 77660 77660 0 0.0
.data 2200 2200 0 0.0
.text 570792 570792 0 0.0
light k32w0+release (read/write) 668788 668788 0 0.0
.bss 77364 77364 0 0.0
.data 2188 2188 0 0.0
.text 570124 570124 0 0.0
lock k32w0+release (read/write) 625400 625400 0 0.0
.bss 75500 75500 0 0.0
.data 2132 2132 0 0.0
.text 545040 545040 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12052036 12052036 0 0.0
(read/write) 729208 729208 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671424 671424 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585300 585300 0 0.0
.text 9736468 9736468 0 0.0
thermostat-no-ble arm64 (read only) 2517204 2516660 -544 -0.0
(read/write) 145320 145320 0 0.0
.bss 56488 56488 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151232 151232 0 0.0
.text 2103680 2103136 -544 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467864 2467864 0 0.0
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1430508 1430508 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164032 1163904 -128 -0.0
bss 143559 143559 0 0.0
rodata 134428 134428 0 0.0
text 806180 806056 -124 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1369324 1369196 -128 -0.0
bss 106022 106022 0 0.0
rodata 211868 211868 0 0.0
text 765944 765816 -128 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1109636 1109508 -128 -0.0
bss 142715 142715 0 0.0
rodata 111472 111472 0 0.0
text 775700 775572 -128 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840832 840832 0 0.0
(read/write) 1760268 1760140 -128 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189840 189840 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1253002 1252941 -61 -0.0
.debug_aranges 111520 111520 0 0.0
.debug_frame 374656 374652 -4 -0.0
.debug_info 28049351 28048633 -718 -0.0
.debug_line 3793551 3793380 -171 -0.0
.debug_loc 3686388 3686363 -25 -0.0
.debug_ranges 363312 363288 -24 -0.0
.debug_str 3524066 3524072 6 0.0
.heap 840832 840832 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 579749 579755 6 0.0
.symtab 425248 425216 -32 -0.0
.text 1559368 1559240 -128 -0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841648 841648 0 0.0
(read/write) 1701084 1700940 -144 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189032 189032 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238589 1238528 -61 -0.0
.debug_aranges 110784 110784 0 0.0
.debug_frame 377092 377088 -4 -0.0
.debug_info 27596786 27596070 -716 -0.0
.debug_line 3802017 3801846 -171 -0.0
.debug_loc 3670002 3669977 -25 -0.0
.debug_ranges 361280 361256 -24 -0.0
.debug_str 3510523 3510529 6 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540171 540177 6 0.0
.symtab 410512 410480 -32 -0.0
.text 1501000 1500856 -144 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849960 849960 0 0.0
(read/write) 1614436 1614436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180920 180920 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1073495 1073495 0 0.0
.debug_aranges 102992 102992 0 0.0
.debug_frame 347352 347352 0 0.0
.debug_info 22937592 22937593 1 0.0
.debug_line 3353714 3353714 0 0.0
.debug_loc 3348612 3348612 0 0.0
.debug_ranges 320224 320224 0 0.0
.debug_str 3314234 3314234 0 0.0
.heap 849960 849960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476007 476007 0 0.0
.symtab 378320 378320 0 0.0
.text 1422664 1422664 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844984 844984 0 0.0
(read/write) 1648236 1648236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185888 185888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1075482 1075482 0 0.0
.debug_aranges 103432 103432 0 0.0
.debug_frame 349236 349236 0 0.0
.debug_info 2318102 23181025 -1 -0.0
.debug_line 3355488 3355488 0 0.0
.debug_loc 3370771 3370771 0 0.0
.debug_ranges 322368 322368 0 0.0
.debug_str 3328855 3328855 0 0.0
.heap 844984 844984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478802 478802 0 0.0
.symtab 380496 380496 0 0.0
.text 1451488 1451488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150468 1150468 0 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597568 597568 0 0.0
lock-app qpg6105+debug (read/write) 1117820 1117820 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 564916 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015412 1015212 -200 -0.0
bss 97928 97928 0 0.0
text 686390 686186 -204 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951392 951184 -208 -0.0
bss 96980 96980 0 0.0
text 648208 648004 -204 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 855812 855812 0 0.0
bss 89108 89108 0 0.0
text 578640 578640 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871540 871540 0 0.0
bss 89192 89192 0 0.0
text 592656 592658 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949584 949584 0 0.0
bss 97336 97336 0 0.0
text 658712 658710 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882956 882956 0 0.0
bss 90136 90136 0 0.0
text 602494 602494 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875840 875640 -200 -0.0
bss 90584 90584 0 0.0
text 594278 594080 -198 -0.0

@bzbarsky-apple bzbarsky-apple merged commit cf83805 into project-chip:master Feb 17, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@lpbeliveau-silabs @bzbarsky-apple
Scenes: emberAfCurrentCommand and emberAfCurrentEndpoint removal (pro…
1a1ff68 
…ject-chip#25136)

* Removed use of emberAfCurrentCommand and emberAfCurrentEndpoint in scenes.cpp

* Restyled by clang-format

* Fix build.

---------

Co-authored-by: Boris Zbarsky <[email protected]>
@lpbeliveau-silabs lpbeliveau-silabs deleted the feature/scene_remove_af_command_endpoint branch December 10, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpbeliveau-silabs @msandstedt @bzbarsky-apple @jmartinez-silabs