Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that we don't miss lookup result notifications. #25103

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Make sure that we don't miss lookup result notifications. #25103

merged 1 commit into from
Feb 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 16, 2023 •
edited
Loading

If we cross our min lookup time boundary between when we get a result and when the next ReArmTimer call happens, we want to make sure we don't end up waiting until our max lookup boundary.

Fixes #25049

@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 16, 2023
Closed
@bzbarsky-apple bzbarsky-apple force-pushed the fix-lookup-result-timing branch from a92b1ad to 4c7578a Compare February 16, 2023 04:40
@github-actions github-actions bot added the lib label Feb 16, 2023
@github-actions
Copy link

PR #25103: Size comparison from b2b6e0f to 4c7578a

Increases (1 build for cc32xx)
platform target config section b2b6e0f 4c7578a change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 641873 16 0.0
.debug_info 20338086 20338166 80 0.0
.debug_line 2657824 2657894 70 0.0
.debug_loc 2790649 2790722 73 0.0
.debug_ranges 281568 281592 24 0.0
.text 534036 534052 16 0.0
Full report (1 build for cc32xx)
platform target config section b2b6e0f 4c7578a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641873 16 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338086 20338166 80 0.0
.debug_line 2657824 2657894 70 0.0
.debug_loc 2790649 2790722 73 0.0
.debug_ranges 281568 281592 24 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534052 16 0.0

@bzbarsky-apple
Make sure that we don't miss lookup result notifications.
0fae37d 
If we cross our min lookup time boundary between when we get a result
and when the next ReArmTimer call happens, we want to make sure we
don't end up waiting until our max lookup boundary.

Fixes project-chip#25049
@bzbarsky-apple bzbarsky-apple force-pushed the fix-lookup-result-timing branch from 4c7578a to 0fae37d Compare February 16, 2023 14:11
@github-actions
Copy link

PR #25103: Size comparison from a8b7ed1 to 0fae37d

Increases (1 build for cc32xx)
platform target config section a8b7ed1 0fae37d change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 641873 16 0.0
.debug_info 20347054 20347133 79 0.0
.debug_line 2658245 2658315 70 0.0
.debug_loc 2791387 2791460 73 0.0
.debug_ranges 281600 281624 24 0.0
.text 534036 534052 16 0.0
Full report (1 build for cc32xx)
platform target config section a8b7ed1 0fae37d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641873 16 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20347054 20347133 79 0.0
.debug_line 2658245 2658315 70 0.0
.debug_loc 2791387 2791460 73 0.0
.debug_ranges 281600 281624 24 0.0
.debug_str 3015122 3015122 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534052 16 0.0

@bzbarsky-apple bzbarsky-apple merged commit 66d35fb into project-chip:master Feb 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-lookup-result-timing branch February 20, 2023 18:55
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Make sure that we don't miss lookup result notifications. (project-ch…
71f66b8 
…ip#25103)

If we cross our min lookup time boundary between when we get a result
and when the next ReArmTimer call happens, we want to make sure we
don't end up waiting until our max lookup boundary.

Fixes project-chip#25049
GabrielCouturier pushed a commit to NXP/matter that referenced this pull request May 12, 2023
@bzbarsky-apple @crlonxp
Make sure that we don't miss lookup result notifications. (project-ch…
0f3f1c6 
…ip#25103)

If we cross our min lookup time boundary between when we get a result
and when the next ReArmTimer call happens, we want to make sure we
don't end up waiting until our max lookup boundary.

Fixes project-chip#25049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DNSSD] Address resolve minimum lookup time seems to be too small for MTD/FTD Thread devices.
3 participants
@bzbarsky-apple @andy31415 @Damian-Nordic