Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align WiFi network diagnostics XML to spec changes. #25094

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 15, 2023

REVIEW NOTE: Only the first changeset here has manual changes.

REVIEW NOTE: Please pay particular attention to:

  • src/platform/Infineon/PSOC6/NetworkCommissioningWiFiDriver.cpp
  • src/platform/nxp/mw320/ConnectivityManagerImpl.cpp

More spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6178

Fixes #24996

@github-actions
Copy link

PR #25094: Size comparison from 80ee243 to 4dc9c04

Increases (1 build for cc32xx)
platform target config section 80ee243 4dc9c04 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2657822 2657824 2 0.0
.debug_loc 2790649 2790663 14 0.0
.debug_str 3003658 3006470 2812 0.1
.strtab 376514 376588 74 0.0
Decreases (1 build for cc32xx)
platform target config section 80ee243 4dc9c04 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338088 20330084 -8004 -0.0
Full report (1 build for cc32xx)
platform target config section 80ee243 4dc9c04 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338088 20330084 -8004 -0.0
.debug_line 2657822 2657824 2 0.0
.debug_loc 2790649 2790663 14 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3006470 2812 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376588 74 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the rename-wifi-diagnostics branch from 4dc9c04 to b056464 Compare February 16, 2023 01:10
@bzbarsky-apple bzbarsky-apple force-pushed the rename-wifi-diagnostics branch 3 times, most recently from d04b8ed to c0e66d7 Compare February 16, 2023 02:02
@github-actions
Copy link

PR #25094: Size comparison from 83dd188 to c0e66d7

Increases (1 build for cc32xx)
platform target config section 83dd188 c0e66d7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931537 22 0.0
.debug_loc 2790649 2790709 60 0.0
.debug_str 3003658 3006533 2875 0.1
.strtab 376514 376646 132 0.0
Decreases (1 build for cc32xx)
platform target config section 83dd188 c0e66d7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338085 20330167 -7918 -0.0
.debug_line 2657824 2657821 -3 -0.0
Full report (1 build for cc32xx)
platform target config section 83dd188 c0e66d7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931537 22 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338085 20330167 -7918 -0.0
.debug_line 2657824 2657821 -3 -0.0
.debug_loc 2790649 2790709 60 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3006533 2875 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376646 132 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the rename-wifi-diagnostics branch from c0e66d7 to 3b726b1 Compare February 16, 2023 03:42
@github-actions
Copy link

PR #25094: Size comparison from 0de7baa to 3b726b1

Increases (1 build for cc32xx)
platform target config section 0de7baa 3b726b1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931537 22 0.0
.debug_loc 2790649 2790709 60 0.0
.debug_str 3003658 3006533 2875 0.1
.strtab 376514 376646 132 0.0
Decreases (1 build for cc32xx)
platform target config section 0de7baa 3b726b1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338087 20330167 -7920 -0.0
.debug_line 2657824 2657821 -3 -0.0
Full report (1 build for cc32xx)
platform target config section 0de7baa 3b726b1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931537 22 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338087 20330167 -7920 -0.0
.debug_line 2657824 2657821 -3 -0.0
.debug_loc 2790649 2790709 60 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3006533 2875 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376646 132 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the rename-wifi-diagnostics branch from 3b726b1 to 396eeae Compare February 16, 2023 20:51
@github-actions
Copy link

PR #25094: Size comparison from e08d4e5 to 396eeae

Increases (6 builds for bl602, bl702, cc32xx, qpg)
platform target config section e08d4e5 396eeae change % change
bl602 lighting-app bl602 (read/write) 1349102 1349110 8 0.0
.text 1025366 1025372 6 0.0
bl602+rpc (read/write) 1394270 1394278 8 0.0
.text 1056042 1056050 8 0.0
bl702 lighting-app bl702 .debug_abbrev 1551468 1551600 132 0.0
.debug_loc 3414273 3414280 7 0.0
.debug_str 3575307 3578182 2875 0.1
.strtab 574057 574189 132 0.0
bl702+rpc .debug_abbrev 1699936 1700068 132 0.0
.debug_loc 3611135 3611184 49 0.0
.debug_str 3978811 3981686 2875 0.1
.strtab 635116 635248 132 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 930151 930173 22 0.0
.debug_loc 2791404 2791435 31 0.0
.debug_str 3015052 3017927 2875 0.1
.strtab 376514 376646 132 0.0
qpg lighting-app qpg6105+debug (read/write) 1150460 1150468 8 0.0
.text 597560 597568 8 0.0
Decreases (3 builds for bl702, cc32xx)
platform target config section e08d4e5 396eeae change % change
bl702 lighting-app bl702 .debug_info 40645880 40637445 -8435 -0.0
.text 954764 954762 -2 -0.0
bl702+rpc .debug_info 45055035 45046575 -8460 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330253 20322495 -7758 -0.0
.debug_line 2658243 2658237 -6 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section e08d4e5 396eeae change % change
bl602 lighting-app bl602 (read/write) 1349102 1349110 8 0.0
.bss 94834 94834 0 0.0
.data 9736 9736 0 0.0
.text 1025366 1025372 6 0.0
bl602+rpc (read/write) 1394270 1394278 8 0.0
.bss 102882 102882 0 0.0
.data 10128 10128 0 0.0
.text 1056042 1056050 8 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1187451 1187451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1551468 1551600 132 0.0
.debug_aranges 134384 134384 0 0.0
.debug_frame 492440 492440 0 0.0
.debug_info 40645880 40637445 -8435 -0.0
.debug_line 5282334 5282334 0 0.0
.debug_loc 3414273 3414280 7 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3575307 3578182 2875 0.1
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107552 107552 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574057 574189 132 0.0
.symtab 173584 173584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 954764 954762 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280623 1280623 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1699936 1700068 132 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520188 520188 0 0.0
.debug_info 45055035 45046575 -8460 -0.0
.debug_line 5681330 5681330 0 0.0
.debug_loc 3611135 3611184 49 0.0
.debug_ranges 395960 395960 0 0.0
.debug_str 3978811 3981686 2875 0.1
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122192 122192 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635116 635248 132 0.0
.symtab 192048 192048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032162 1032162 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930151 930173 22 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20330253 20322495 -7758 -0.0
.debug_line 2658243 2658237 -6 -0.0
.debug_loc 2791404 2791435 31 0.0
.debug_ranges 281600 281600 0 0.0
.debug_str 3015052 3017927 2875 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376646 132 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12050772 12050772 0 0.0
(read/write) 729208 729208 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671424 671424 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585300 585300 0 0.0
.text 9735204 9735204 0 0.0
thermostat-no-ble arm64 (read only) 2517204 2517204 0 0.0
(read/write) 145320 145320 0 0.0
.bss 56488 56488 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151232 151232 0 0.0
.text 2103680 2103680 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150460 1150468 8 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597560 597568 8 0.0
lock-app qpg6105+debug (read/write) 1117820 1117820 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 564916 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the rename-wifi-diagnostics branch from 396eeae to aa0fca8 Compare February 16, 2023 23:14
@github-actions
Copy link

PR #25094: Size comparison from 50ed10e to aa0fca8

Increases (1 build for cc32xx)
platform target config section 50ed10e aa0fca8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 930151 930173 22 0.0
.debug_loc 2791404 2791435 31 0.0
.debug_str 3015052 3017927 2875 0.1
.strtab 376514 376646 132 0.0
Decreases (1 build for cc32xx)
platform target config section 50ed10e aa0fca8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330253 20322495 -7758 -0.0
.debug_line 2658243 2658237 -6 -0.0
Full report (1 build for cc32xx)
platform target config section 50ed10e aa0fca8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930151 930173 22 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20330253 20322495 -7758 -0.0
.debug_line 2658243 2658237 -6 -0.0
.debug_loc 2791404 2791435 31 0.0
.debug_ranges 281600 281600 0 0.0
.debug_str 3015052 3017927 2875 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376646 132 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@Damian-Nordic Damian-Nordic merged commit 6083a3f into project-chip:master Feb 17, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-wifi-diagnostics branch February 17, 2023 14:42
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Align WiFi network diagnostics XML to spec changes.

More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6178

Fixes project-chip#24996

* Auto-update ZAP files.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XML] Update Wi-Fi Network Diagnostics Cluster XML to match updated spec
4 participants