-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align WiFi network diagnostics XML to spec changes. #25094
Merged
Damian-Nordic
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-wifi-diagnostics
Feb 17, 2023
Merged
Align WiFi network diagnostics XML to spec changes. #25094
Damian-Nordic
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-wifi-diagnostics
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
controller
darwin
esp32
examples
linux
platform
scripts
labels
Feb 15, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
February 15, 2023 23:33
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 15, 2023 23:33
PR #25094: Size comparison from 80ee243 to 4dc9c04 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
force-pushed
the
rename-wifi-diagnostics
branch
from
February 16, 2023 01:10
4dc9c04
to
b056464
Compare
bzbarsky-apple
force-pushed
the
rename-wifi-diagnostics
branch
3 times, most recently
from
February 16, 2023 02:02
d04b8ed
to
c0e66d7
Compare
PR #25094: Size comparison from 83dd188 to c0e66d7 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
force-pushed
the
rename-wifi-diagnostics
branch
from
February 16, 2023 03:42
c0e66d7
to
3b726b1
Compare
PR #25094: Size comparison from 0de7baa to 3b726b1 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Feb 16, 2023
ReneJosefsen
approved these changes
Feb 16, 2023
bzbarsky-apple
force-pushed
the
rename-wifi-diagnostics
branch
from
February 16, 2023 20:51
3b726b1
to
396eeae
Compare
PR #25094: Size comparison from e08d4e5 to 396eeae Increases (6 builds for bl602, bl702, cc32xx, qpg)
Decreases (3 builds for bl702, cc32xx)
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
|
bzbarsky-apple
force-pushed
the
rename-wifi-diagnostics
branch
from
February 16, 2023 23:14
396eeae
to
aa0fca8
Compare
PR #25094: Size comparison from 50ed10e to aa0fca8 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Damian-Nordic
approved these changes
Feb 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Align WiFi network diagnostics XML to spec changes. More spec changes happened in CHIP-Specifications/connectedhomeip-spec#6178 Fixes project-chip#24996 * Auto-update ZAP files. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first changeset here has manual changes.
REVIEW NOTE: Please pay particular attention to:
More spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6178
Fixes #24996